Miri: run panic-catching tests in liballoc #66662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
commented
Nov 23, 2019
| @@ -1643,6 +1648,9 @@ fn panic_safe() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Set default panic hook again. | |||
| drop(panic::take_hook()); | |||
There was a problem hiding this comment.
Setting the global panic hook in a test seems like a bad idea anyway as it affects other tests running in parallel, but this way at least we do not affect tests running later.
Aaron1011
reviewed
Nov 23, 2019
JohnCSimon
added
S-waiting-on-author
|
Ping from triage: |
|
This is waiting for review. r? @dtolnay |
RalfJung
added
S-waiting-on-review
dtolnay
approved these changes
Nov 30, 2019
|
@bors r+ |
|
📌 Commit a229979 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a229979 with merge e5292bd57e5d24e3688d79c358690cc6a3d46c1e... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry spurious |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 1, 2019
Miri: run panic-catching tests in liballoc I also converted two tests from using `thread::spawn(...).join()` just for catching panics, to `catch_panic`, so that Miri can run them.
bors
added a commit
that referenced
this pull request
Dec 1, 2019
Rollup of 9 pull requests Successful merges: - #66503 (More useful test error messages on should_panic(expected=...) mismatch) - #66662 (Miri: run panic-catching tests in liballoc) - #66679 (Improve lifetime errors with implicit trait object lifetimes) - #66726 (Use recursion_limit for const eval stack limit) - #66790 (Do `min_const_fn` checks for `SetDiscriminant`s target) - #66832 (const_prop: detect and avoid catching Miri errors that require allocation) - #66880 (Add long error code explanation message for E0203) - #66890 (Format liballoc with rustfmt) - #66896 (pass Queries to compiler callbacks) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also converted two tests from using
thread::spawn(...).join()just for catching panics, tocatch_panic, so that Miri can run them.