Skip to content

Fix angle bracket formatting when dumping MIR debug vars #66988

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Fix angle bracket formatting when dumping MIR debug vars #66988

merged 1 commit into from
Dec 6, 2019

Conversation

osa1
Copy link
Contributor

@osa1 osa1 commented Dec 3, 2019

Fixes #66985

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2019
@osa1
Copy link
Contributor Author

osa1 commented Dec 3, 2019

Does this need a test? Where do I add it? Do we have any other tests that invoke dot to copy?

@matthewjasper
Copy link
Contributor

The graphviz output of the compiler is untested. You could add a test in src/test/run-make. I'm not sure how I feel about requiring graphviz in the tests though.

@osa1
Copy link
Contributor Author

osa1 commented Dec 4, 2019

The graphviz output of the compiler is untested

OK, in that case this is good to go.

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 4, 2019

📌 Commit b85d5f4 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 6, 2019
Fix angle bracket formatting when dumping MIR debug vars

Fixes rust-lang#66985
bors added a commit that referenced this pull request Dec 6, 2019
Rollup of 11 pull requests

Successful merges:

 - #66846 (Make try_mark_previous_green aware of cycles.)
 - #66959 (Remove potential cfgs duplicates)
 - #66988 (Fix angle bracket formatting when dumping MIR debug vars)
 - #66998 (Modified the testcases for VxWorks)
 - #67008 (rustdoc: Add test for fixed issue)
 - #67023 (SGX: Fix target linker used by bootstrap)
 - #67033 (Migrate to LLVM{Get,Set}ValueName2)
 - #67049 (Simplify {IoSlice, IoSliceMut}::advance examples and tests)
 - #67054 (codegen "unreachable" for invalid SetDiscriminant)
 - #67081 (Fix Query type docs)
 - #67085 (Remove boxed closures in address parser.)

Failed merges:

r? @ghost
@bors bors merged commit b85d5f4 into rust-lang:master Dec 6, 2019
@osa1 osa1 deleted the issue66985 branch March 2, 2021 07:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Zunpretty=mir-cfg generates invalid dot syntax
4 participants