Skip to content

Detail transitive containment in E0588 diagnostic #67956

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

varkor
Copy link
Member

@varkor varkor commented Jan 7, 2020

Fixes #67383.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2020
@varkor varkor force-pushed the E0588-provide-context branch from d893b8e to d11b560 Compare January 7, 2020 00:01
@rust-highfive

This comment has been minimized.

@varkor varkor force-pushed the E0588-provide-context branch 3 times, most recently from 8e37bd3 to 3ab95ce Compare January 7, 2020 02:16
@varkor
Copy link
Member Author

varkor commented Jan 16, 2020

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned cramertj Jan 16, 2020
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 16, 2020

📌 Commit 3ab95ce has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 17, 2020
…ebank

Detail transitive containment in E0588 diagnostic

Fixes rust-lang#67383.
bors added a commit that referenced this pull request Jan 17, 2020
Rollup of 6 pull requests

Successful merges:

 - #67956 (Detail transitive containment in E0588 diagnostic)
 - #68153 (resolve: Point at the private item definitions in privacy errors)
 - #68195 (Account for common `impl Trait`/`dyn Trait` return type errors)
 - #68288 (Fix some of the rustfmt fallout in Miri)
 - #68292 (don't clone types that are copy)
 - #68301 (Don't propagate __RUST_TEST_INVOKE to subprocess)

Failed merges:

r? @ghost
@bors bors merged commit 3ab95ce into rust-lang:master Jan 17, 2020
@varkor varkor deleted the E0588-provide-context branch January 17, 2020 13:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
5 participants