Skip to content

Extend support of _ in type parameters #68071

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2020
Merged

Extend support of _ in type parameters #68071

merged 2 commits into from
Jan 10, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jan 9, 2020

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2020
@rust-highfive

This comment has been minimized.

# to view
Centril
Centril reviewed Jan 9, 2020
View reviewed changes
@estebank
Extend support of _ in type parameters
c751961 
 - Account for `impl Trait<_>`.
 - Provide a reasonable `Span` for empty `Generics` in `impl`s.
 - Account for `fn foo<_>(_: _) {}` to suggest `fn foo<T>(_: T) {}`.
 - Fix rust-lang#67995.
@estebank
Copy link
Contributor Author

estebank commented Jan 9, 2020

r? @Centril

@Centril
Copy link
Contributor

Centril commented Jan 9, 2020

r=me with ^-- addressed + comments in private

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2020
@rust-highfive

This comment has been minimized.

# to view
@estebank
Copy link
Contributor Author

estebank commented Jan 9, 2020

@bors r=Centril

@bors
Copy link
Collaborator

bors commented Jan 9, 2020

📌 Commit 6e04cf0 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 9, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
@Centril
Rollup merge of rust-lang#68071 - estebank:ice-67995, r=Centril
25e57f4 
Extend support of `_` in type parameters

 - Account for `impl Trait<_>`.
 - Provide a reasonable `Span` for empty `Generics` in `impl`s.
 - Account for `fn foo<_>(_: _) {}` to suggest `fn foo<T>(_: T) {}`.
 - Fix rust-lang#67995. Follow up to rust-lang#67597.
@Centril Centril mentioned this pull request Jan 10, 2020
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
@Centril
Rollup merge of rust-lang#68071 - estebank:ice-67995, r=Centril
2307f0c 
Extend support of `_` in type parameters

 - Account for `impl Trait<_>`.
 - Provide a reasonable `Span` for empty `Generics` in `impl`s.
 - Account for `fn foo<_>(_: _) {}` to suggest `fn foo<T>(_: T) {}`.
 - Fix rust-lang#67995. Follow up to rust-lang#67597.
@Centril Centril mentioned this pull request Jan 10, 2020
Merged
bors added a commit that referenced this pull request Jan 10, 2020
@bors
Auto merge of #68078 - Centril:rollup-qvq052k, r=Centril
2d8d559 
Rollup of 6 pull requests

Successful merges:

 - #66463 (Point at opaque and closure type definitions in type errors)
 - #67501 (Reduce special treatment for zsts)
 - #67820 (Parse the syntax described in RFC 2632)
 - #67922 (rustc_ast_lowering: misc cleanup & rustc dep reductions)
 - #68071 (Extend support of `_` in type parameters)
 - #68073 (expect `fn` after `const unsafe` / `const extern`)

Failed merges:

r? @ghost
@bors bors merged commit 6e04cf0 into rust-lang:master Jan 10, 2020
@estebank estebank mentioned this pull request Feb 13, 2020
Closed
@estebank estebank mentioned this pull request Feb 13, 2020
Merged
@pnkfelix pnkfelix mentioned this pull request Feb 20, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#69148 - estebank:cold-as-ice, r=oli-obk
0c3a8cd 
Account for bounds and asociated items when denying `_`

Fix rust-lang#68801, rust-lang#69204. Follow up to rust-lang#67597 and rust-lang#68071.

Output for the original ICE report:

```
    Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca)
error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/producers.rs:43:70
   |
43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> {
   |                                                                      ^ not allowed in type signatures       ^ not allowed in type signatures

error: aborting due to previous error
```
bors added a commit that referenced this pull request Feb 28, 2020
@bors
Auto merge of #69148 - estebank:cold-as-ice, r=oli-obk
eaa02f5 
Account for bounds and asociated items when denying `_`

Fix #68801, #69204. Follow up to #67597 and #68071.

Output for the original ICE report:

```
    Checking vinoteca v5.0.0 (/Users/ekuber/workspace/vinoteca)
error[E0121]: the type placeholder `_` is not allowed within types on item signatures
  --> src/producers.rs:43:70
   |
43 | pub fn top<Table: diesel::Table + diesel::query_dsl::InternalJoinDsl<_, diesel::query_source::joins::Inner, _>>(table: Table, limit: usize, connection: DbConn) -> RestResult<Vec<TopWineType>> {
   |                                                                      ^ not allowed in type signatures       ^ not allowed in type signatures

error: aborting due to previous error
```
@estebank estebank deleted the ice-67995 branch November 9, 2023 05:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: Returning impl Trait with placeholder type parameter
5 participants
@estebank @rust-highfive @Centril @bors @matthewjasper