-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[do not merge] Try turning on MIR inliner by default #68213
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@bors try |
Awaiting bors try build completion |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-azure |
Queued dc0f962 with parent c06e4ac, future comparison URL. |
Finished benchmarking try commit dc0f962, comparison URL. |
Interestingly, we're already seeing a lot of improvements across most tests which is very nice! Looking at the (major) regressions, I'm seeing the following patterns:
|
This may be the monomorphization of the mir body: rust/src/librustc_mir/transform/inline.rs Lines 125 to 133 in 632387f
|
#68606 may help with the |
Try turning on the MIR inliner by default to measure the performance impact.
Rebased on top of #68170 to get that fix.
r? @ghost