Skip to content

[do not merge] Try turning on MIR inliner by default #68213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

wesleywiser
Copy link
Member

Try turning on the MIR inliner by default to measure the performance impact.

Rebased on top of #68170 to get that fix.

r? @ghost

@wesleywiser
Copy link
Member Author

@bors try
@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Jan 14, 2020

⌛ Trying commit a3db620 with merge dc0f962...

bors added a commit that referenced this pull request Jan 14, 2020
[do not merge] Try turning on MIR inliner by default

Try turning on the MIR inliner by default to measure the performance impact.

Rebased on top of #68170 to get that fix.

r? @ghost
@rust-highfive

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jan 14, 2020

☀️ Try build successful - checks-azure
Build commit: dc0f962 (dc0f962493ef0ce61d14530aee40c9fe64de0caf)

@rust-timer
Copy link
Collaborator

Queued dc0f962 with parent c06e4ac, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit dc0f962, comparison URL.

@wesleywiser
Copy link
Member Author

Interestingly, we're already seeing a lot of improvements across most tests which is very nice!

Looking at the (major) regressions, I'm seeing the following patterns:

@bjorn3
Copy link
Member

bjorn3 commented Jan 15, 2020

normalize_ty_after_erasing_regions being called more times:

This may be the monomorphization of the mir body:

let callee_body = if self.consider_optimizing(callsite, callee_body) {
self.tcx.subst_and_normalize_erasing_regions(
&callsite.substs,
param_env,
callee_body,
)
} else {
continue;
};

@Zoxc
Copy link
Contributor

Zoxc commented Jan 29, 2020

#68606 may help with the await-call-tree regression.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants