Skip to content

Update LLVM #68299

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update LLVM #68299

wants to merge 1 commit into from

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Jan 17, 2020

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2020
@nagisa
Copy link
Member

nagisa commented Jan 17, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 17, 2020

📌 Commit f3d6310 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2020
@nikic
Copy link
Contributor

nikic commented Jan 17, 2020

The cherry-pick of the last commit is incorrect (incorrect as in going to cause miscompiles), because it does not pick up two dependent changes. The cherry-picks also need to go on the rustc/9.0-2019-12-19 branch, which #68030 updates to.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 17, 2020
@tmandry
Copy link
Member Author

tmandry commented Jan 17, 2020

Oops, that was clumsy of me. Thanks for catching this. I'll tag you in my next attempt.

@tmandry tmandry closed this Jan 17, 2020
@tmandry tmandry deleted the llvmup branch January 17, 2020 19:25
@tmandry tmandry mentioned this pull request Jan 17, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
6 participants
@tmandry @rust-highfive @nagisa @bors @nikic @alexcrichton