Also share drop-glue when compiling with -Zshare-generics (i.e. at opt-level=0) #68414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
bors
added a commit
that referenced
this pull request
Jan 21, 2020
Also share drop-glue when compiling with -Zshare-generics (i.e. at opt-level=0) This PR adds drop-glue to the set of monomorphizations that can be shared across crates via `-Zshare-generics`. This version of the PR might have detrimental effects on performance as it makes lots of stuff dependent on a single query results (`upstream_monomorphizations_for(def_id_of_drop_in_place)`). That should be fixable but let's do a perf run first. Potentially fixes issue #64140. (cc @alexcrichton) The changes here are related to @matthewjasper's #67332 but should be mostly orthogonal. r? @ghost
|
☀️ Try build successful - checks-azure |
|
Queued e9acaef with parent ce361fb, future comparison URL. |
|
Finished benchmarking try commit e9acaef, comparison URL. |
|
Hard to get a better try run than that :) r=me on the code here too |
|
Hm, I find the results a bit underwhelming actually. Let's see if having a separate query drop-glue improves things. If not, merging this simpler version is good too. There's some nice cleanup/documentation in there. |
|
@bors try @rust-timer queue This adds another query layer for drop-glue so we get better granularity (an approach that could be trivially extend to similar cases like Unfortunately I also found a bug. Running UI tests with |
|
Awaiting bors try build completion |
bors
added a commit
that referenced
this pull request
Jan 22, 2020
Also share drop-glue when compiling with -Zshare-generics (i.e. at opt-level=0) This PR adds drop-glue to the set of monomorphizations that can be shared across crates via `-Zshare-generics`. This version of the PR might have detrimental effects on performance as it makes lots of stuff dependent on a single query results (`upstream_monomorphizations_for(def_id_of_drop_in_place)`). That should be fixable but let's do a perf run first. Potentially fixes issue #64140. (cc @alexcrichton) The changes here are related to @matthewjasper's #67332 but should be mostly orthogonal. r? @ghost
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☀️ Try build successful - checks-azure |
|
Queued d9ce420 with parent 2f688ac, future comparison URL. |
|
Alright, I found the bug. Turns out |
|
Finished benchmarking try commit d9ce420, comparison URL. |
used outside of the LLVM backend.
michaelwoerister
force-pushed
the
share-drop-glue
branch
from
9494974 to
d3ca81c
Compare
|
This is ready for an actual review. |
|
r? @alexcrichton ( |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
michaelwoerister
force-pushed
the
share-drop-glue
branch
from
d3ca81c to
168c6a1
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
michaelwoerister
force-pushed
the
share-drop-glue
branch
from
168c6a1 to
7bbdeb6
Compare
alexcrichton
approved these changes
Jan 23, 2020
This reduces the amount of invalidated data when new types are add to upstream crates.
michaelwoerister
force-pushed
the
share-drop-glue
branch
from
7bbdeb6 to
197cc1e
Compare
|
@bors r=alexcrichton Thanks for the review! |
|
📌 Commit 197cc1e has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors rollup=never |
bors
added a commit
that referenced
this pull request
Jan 24, 2020
Also share drop-glue when compiling with -Zshare-generics (i.e. at opt-level=0) This PR adds drop-glue to the set of monomorphizations that can be shared across crates via `-Zshare-generics`. This version of the PR might have detrimental effects on performance as it makes lots of stuff dependent on a single query results (`upstream_monomorphizations_for(def_id_of_drop_in_place)`). That should be fixable but let's do a perf run first. Potentially fixes issue #64140. (cc @alexcrichton) The changes here are related to @matthewjasper's #67332 but should be mostly orthogonal. r? @ghost
|
☀️ Test successful - checks-azure |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds drop-glue to the set of monomorphizations that can be shared across crates via
-Zshare-generics.This version of the PR might have detrimental effects on performance as it makes lots of stuff dependent on a single query results (
upstream_monomorphizations_for(def_id_of_drop_in_place)). That should be fixable but let's do a perf run first.Potentially fixes issue #64140. (cc @alexcrichton)
The changes here are related to @matthewjasper's #67332 but should be mostly orthogonal.
r? @ghost