-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Fix null synthetic_implementors error #68598
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix null synthetic_implementors error #68598
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Nice, r=me once the tidy error has been fixed. Nominating for beta backport because it looks like it's just been branched. |
@ollie27 btw, don't forget to add a team label when adding beta-nominated. :) |
65be93e
to
0754461
Compare
Updated! |
@bors: r=ollie27 |
📌 Commit 0754461 has been approved by |
…mplementors, r=ollie27 Fix null synthetic_implementors error Fixes rust-lang#68584. r? @ollie27 cc @kinnison
Rollup of 7 pull requests Successful merges: - #67722 (Minor: note how Any is an unsafe trait in SAFETY comments) - #68586 (Make conflicting_repr_hints a deny-by-default c-future-compat lint) - #68598 (Fix null synthetic_implementors error) - #68603 (Changelog: Demonstrate final build-override syntax) - #68609 (Set lld flavor for MSVC to link.exe) - #68611 (Correct ICE caused by macros generating invalid spans.) - #68627 (Document that write_all will not call write if given an empty buffer) Failed merges: r? @ghost
@rust-lang/rustdoc If this is to get into beta in time (i.e., before beta becomes stable) then it needs to be approved roughly in the next 3 days. |
@Mark-Simulacrum I add the tag for it. |
[stable] Release 1.42.0 This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs: * #69754: Update deprecation version to 1.42 for Error::description * #69753: Do not ICE when matching an uninhabited enum's field * #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful * #68598: Fix null synthetic_implementors error In addition, the release notes are updated to include the remaining compatibility notes. r? @Centril
[stable] Release 1.42.0 This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs: * #69754: Update deprecation version to 1.42 for Error::description * #69753: Do not ICE when matching an uninhabited enum's field * #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful * #68598: Fix null synthetic_implementors error In addition, the release notes are updated to include the remaining compatibility notes. r? @Centril
Fixes #68584.
r? @ollie27
cc @kinnison