Skip to content

Use termize instead of term_size #68626

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Use termize instead of term_size #68626

merged 1 commit into from
Jan 30, 2020

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 29, 2020

termize is a fork of term_size which uses winapi 0.3 instead of 0.2. This is a step towards removing the winapi 0.2 dependency.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 29, 2020
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 29, 2020

cc @JohnTitor

@JohnTitor
Copy link
Member

Oh, it was actually discussed with @estebank who introduced term_size on Zulip. And we've agreed to use termize instead.
Context

@estebank
Copy link
Contributor

r? @estebank @bors r+

@bors
Copy link
Collaborator

bors commented Jan 29, 2020

📌 Commit b0b11d3 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2020
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 29, 2020

This also happens to improve the compile time for rustc_driver from 210s to 30s.

@retep998 Have you noticed excessive linking times with winapi 0.2?

@memoryruins
Copy link
Contributor

memoryruins commented Jan 29, 2020

0.2 takes a toll on compile-times, e.g. EmbarkStudios/rust-ecosystem#42 and rust-lang/cargo#7389

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 30, 2020
Use termize instead of term_size

`termize` is a fork of `term_size` which uses `winapi` 0.3 instead of 0.2. This is a step towards removing the `winapi` 0.2 dependency.

r? @Mark-Simulacrum
bors added a commit that referenced this pull request Jan 30, 2020
Rollup of 6 pull requests

Successful merges:

 - #66648 (Implement clone_from for BTreeMap and BTreeSet)
 - #68468 (BTreeMap: tag and explain unsafe internal functions or assert preconditions)
 - #68626 (Use termize instead of term_size)
 - #68640 (Document remaining undocumented `From` implementations for IPs)
 - #68651 (Document `From` implementation for NonZero nums)
 - #68655 (Fix revision annotations in borrowck-feature-nll-overrides-migrate)

Failed merges:

r? @ghost
@bors bors merged commit b0b11d3 into rust-lang:master Jan 30, 2020
@Zoxc Zoxc deleted the termize branch January 30, 2020 17:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants