-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Move rustc_hir::def_id
to rustc_span::def_id
#68718
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
src/test/run-make-fulldeps/hotplug_codegen_backend/the_backend.rs
Outdated
Show resolved
Hide resolved
This will break most tools - I'll submit follow-up PRs if this PR is merged. |
This is pretty radical. As I mentioned on discord, I'd prefer to have a proof-of-concept implementation of metadata encoding/decoding (using tables for translating between The proof-of-concept implementation can move |
☔ The latest upstream changes (presumably #68133) made this pull request unmergeable. Please resolve the merge conflicts. |
Wouldn't this effectively require importing the This will result in each crate in the graph having a progressively larger We could try to maintain a notion of 'local |
Exactly. |
@Aaron1011 |
@petrochenkov: I ended up needing to make this change in #68941, so this PR may no longer be necessary. |
@Aaron1011 |
0c11437
to
d4874e9
Compare
@petrochenkov: Updated |
r=me with commits squashed. |
For noww, librustc_hir re-exports the `def_id` module from librustc_span, so the rest of rustc can continue to reference rustc_hir::def_id
6ace7d9
to
619051e
Compare
@petrochenkov: Squashed |
@bors r+ |
📌 Commit 619051e has been approved by |
…ochenkov Move `rustc_hir::def_id` to `rustc_span::def_id` This will allow `HygieneData` to refer to `DefId` and `DefIndex`, which will enable proper serialization of Span hygiene information. This also reduces the number of things imported from `rustc_hir`, which might make it easier to remove dependencies on it.
…ochenkov Move `rustc_hir::def_id` to `rustc_span::def_id` This will allow `HygieneData` to refer to `DefId` and `DefIndex`, which will enable proper serialization of Span hygiene information. This also reduces the number of things imported from `rustc_hir`, which might make it easier to remove dependencies on it.
Rollup of 7 pull requests Successful merges: - #68718 (Move `rustc_hir::def_id` to `rustc_span::def_id`) - #68834 (Fix and test implementation of BTreeMap's first/last_entry, pop_first/last) - #68857 (perf: Reduce Vec allocations in normalization by passing &mut Vec) - #68918 (Don't use the word "unwrap" to describe "unwrap" methods) - #68946 (Mark several functions and methods in core::cmp as #[must_use]) - #68958 (Clean up E0277 and E0282 explanations) - #68960 (codegen: misc cleanups around debuginfo scopes and locations.) Failed merges: r? @ghost
Rollup of 7 pull requests Successful merges: - #68718 (Move `rustc_hir::def_id` to `rustc_span::def_id`) - #68834 (Fix and test implementation of BTreeMap's first/last_entry, pop_first/last) - #68857 (perf: Reduce Vec allocations in normalization by passing &mut Vec) - #68918 (Don't use the word "unwrap" to describe "unwrap" methods) - #68946 (Mark several functions and methods in core::cmp as #[must_use]) - #68958 (Clean up E0277 and E0282 explanations) - #68960 (codegen: misc cleanups around debuginfo scopes and locations.) Failed merges: r? @ghost
This will allow
HygieneData
to refer toDefId
andDefIndex
, whichwill enable proper serialization of Span hygiene information.
This also reduces the number of things imported from
rustc_hir
, whichmight make it easier to remove dependencies on it.