Skip to content

Make the SGX arg cleanup implementation a NOP #69068

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

Goirad
Copy link
Contributor

@Goirad Goirad commented Feb 11, 2020

fixes #64304

cc @jethrogb

@rust-highfive
Copy link
Contributor

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2020
@Goirad Goirad changed the title make the sgx arg cleanup implementation a no op Make the SGX arg cleanup implementation a NOP Feb 11, 2020
@jethrogb
Copy link
Contributor

LGTM

@nagisa
Copy link
Member

nagisa commented Feb 11, 2020

@bors r+ as per the LGTM above.

@bors
Copy link
Collaborator

bors commented Feb 11, 2020

📌 Commit 1f6fb33 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2020
@nagisa
Copy link
Member

nagisa commented Feb 11, 2020

@bors r=jethrogb,nagisa

@bors
Copy link
Collaborator

bors commented Feb 11, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Feb 11, 2020

📌 Commit 1f6fb33 has been approved by jethrogb,nagisa

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 13, 2020
…jethrogb,nagisa

Make the SGX arg cleanup implementation a NOP

fixes rust-lang#64304

cc @jethrogb
bors added a commit that referenced this pull request Feb 13, 2020
Rollup of 9 pull requests

Successful merges:

 - #67642 (Relax bounds on HashMap/HashSet)
 - #68848 (Hasten macro parsing)
 - #69008 (Properly use parent generics for opaque types)
 - #69048 (Suggestion when encountering assoc types from hrtb)
 - #69049 (Optimize image sizes)
 - #69050 (Micro-optimize the heck out of LEB128 reading and writing.)
 - #69068 (Make the SGX arg cleanup implementation a NOP)
 - #69082 (When expecting `BoxFuture` and using `async {}`, suggest `Box::pin`)
 - #69104 (bootstrap: Configure cmake when building sanitizer runtimes)

Failed merges:

r? @ghost
@bors bors merged commit 1f6fb33 into rust-lang:master Feb 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SGX's std::env::args function is not thread-safe
6 participants