Skip to content

Use ResultsCursor for elaborate_drops #69156

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 16, 2020

Conversation

ecstatic-morse
Copy link
Contributor

Some cleanup after #68241. The old code was using a custom cursor-like struct called InitializationData.

The old code hard-coded the transfer function for the initialized places
analyses.
@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2020
@eddyb
Copy link
Member

eddyb commented Feb 15, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 15, 2020

📌 Commit 26451d0 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 15, 2020
…ls2, r=eddyb

Use `ResultsCursor` for `elaborate_drops`

Some cleanup after rust-lang#68241. The old code was using a custom cursor-like struct called `InitializationData`.
@Centril
Copy link
Contributor

Centril commented Feb 15, 2020

@bors rollup=never "soundness adjacent change"

@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Collaborator

bors commented Feb 16, 2020

⌛ Testing commit 26451d0 with merge 8040bc9...

bors added a commit that referenced this pull request Feb 16, 2020
Use `ResultsCursor` for `elaborate_drops`

Some cleanup after #68241. The old code was using a custom cursor-like struct called `InitializationData`.
@bors
Copy link
Collaborator

bors commented Feb 16, 2020

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing 8040bc9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 16, 2020
@bors bors merged commit 26451d0 into rust-lang:master Feb 16, 2020
@ecstatic-morse ecstatic-morse deleted the unified-dataflow-impls2 branch October 6, 2020 01:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants