[stable] 1.41.1 release #69359

Mark-Simulacrum · 2020-02-21T21:33:25Z

This backports the following PRs:

Revert "Remove checked_add in Layout::repeat" Revert "Remove checked_add in Layout::repeat" #69241
Do not ICE when encountering yield inside async block Do not ICE when encountering yield inside async block #69175
Correct ICE caused by macros generating invalid spans. Correct ICE caused by macros generating invalid spans. #68611
Changelog: Demonstrate final build-override syntax Changelog: Demonstrate final build-override syntax #68603
Resolve long compile times when evaluating always valid constants Resolve long compile times when evaluating always valid constants #67667
Fix MIR typeck soundness holes Fix MIR typeck soundness holes #69145

This also includes a commit which rustfmt's files which the latter commits touched (and perhaps a bit more) to make rebasing the PRs go more smoothly (thankfully, this should be the last time we need to do so).

I have removed stable-nominated tags from PRs successfully backported.

This fixes a a segfault in safe code, a stable regression. Reported in \rust-lang#69225. This reverts commit a983e05. Also adds a test for the expected behaviour.

Mark-Simulacrum · 2020-02-21T22:36:49Z

@bors try

I'm hoping this works to both make sure everything backported cleanly enough to at least bootstrap and gives us CI artifacts to run crater on.

bors · 2020-02-21T22:37:21Z

⌛ Trying commit 95beef7329637484f6134d53023ffc37483b4b66 with merge a98ec72e2bb7aad59cb96631bf3a148c0be33776...

rust-highfive · 2020-02-21T23:53:04Z

The job dist-x86_64-linux-alt of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-21T23:52:14.4292100Z    Compiling rustc_session v0.0.0 (/checkout/src/librustc_session)
2020-02-21T23:52:36.7424762Z error[E0433]: failed to resolve: use of undeclared type or module `rustc_span`
2020-02-21T23:52:36.7425628Z   --> src/librustc/hir/map/hir_id_validator.rs:24:29
2020-02-21T23:52:36.7426602Z    |
2020-02-21T23:52:36.7427340Z 24 |         sess.delay_span_bug(rustc_span::DUMMY_SP, &message);
2020-02-21T23:52:36.7434699Z 
2020-02-21T23:52:56.0679566Z error: aborting due to previous error
2020-02-21T23:52:56.0683091Z 
2020-02-21T23:52:56.0691551Z For more information about this error, try `rustc --explain E0433`.
---
2020-02-21T23:52:58.4699339Z   local time: Fri Feb 21 23:52:58 UTC 2020
2020-02-21T23:52:59.3101423Z   network time: Fri, 21 Feb 2020 23:52:59 GMT
2020-02-21T23:52:59.3101741Z == end clock drift check ==
2020-02-21T23:52:59.9118123Z 
2020-02-21T23:52:59.9190669Z ##[error]Bash exited with code '1'.
2020-02-21T23:52:59.9254137Z ##[section]Starting: Checkout rust-lang/rust@try to s
2020-02-21T23:52:59.9258595Z ==============================================================================
2020-02-21T23:52:59.9258894Z Task         : Get sources
2020-02-21T23:52:59.9259251Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-21T23:53:17Z

💔 Test failed - checks-azure

This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixes rust-lang#67539

Mark-Simulacrum · 2020-02-22T16:02:03Z

@bors try

bors · 2020-02-22T16:02:14Z

⌛ Trying commit 8f92102 with merge 9ab2cd6...

[stable] 1.41.1 release This backports the following PRs: * Revert "Remove `checked_add` in `Layout::repeat`" #69241 * Do not ICE when encountering `yield` inside `async` block #69175 * Correct ICE caused by macros generating invalid spans. #68611 * Changelog: Demonstrate final build-override syntax #68603 * Resolve long compile times when evaluating always valid constants #67667 * Fix MIR typeck soundness holes #69145 This also includes a commit which rustfmt's files which the latter commits touched (and perhaps a bit more) to make rebasing the PRs go more smoothly (thankfully, this should be the last time we need to do so). I have removed stable-nominated tags from PRs successfully backported.

bors · 2020-02-22T18:34:46Z

💔 Test failed - checks-azure

This helps us have enough disk space for our builders to be able to complete successfully. For now, the choices are ad-hoc and 'definitely not needed'. This should never fail the build, as everything our build needs should be inside Docker.

Mark-Simulacrum · 2020-02-23T02:32:51Z

Cherry-picked #69252 (and marked as stable-accepted). Also beta-nominated (and accepted) that PR, seems harmless and likely necessary on beta too (at least sometimes).

@bors r+ p=100

Hopefully this'll land now (I was hoping to get try artifacts, but now that I think of it "stable" artifacts will work just as well for crater).

bors · 2020-02-23T02:32:52Z

📌 Commit 6d4e588 has been approved by Mark-Simulacrum

bors · 2020-02-23T05:16:18Z

⌛ Testing commit 6d4e588 with merge 606353be600741d569d160359452030ba7b8ab7e...

rust-highfive · 2020-02-23T06:26:51Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-23T06:24:08.5785371Z + 
2020-02-23T06:24:08.5785645Z + warning: any use of this value will cause an error
2020-02-23T06:24:08.5786192Z +   --> $DIR/validate_uninhabited_zsts.rs:14:26
2020-02-23T06:24:08.5786473Z +    |
2020-02-23T06:24:08.5786722Z 10 LL | const FOO: [Empty; 3] = [foo(); 3];
2020-02-23T06:24:08.5787935Z +    | -------------------------^^^^^-----
2020-02-23T06:24:08.5788248Z +    |                          |
2020-02-23T06:24:08.5788594Z +    |                          referenced constant has errors
2020-02-23T06:24:08.5788879Z 12    |
2020-02-23T06:24:08.5788879Z 12    |
2020-02-23T06:24:08.5789116Z 13 note: lint level defined here
2020-02-23T06:24:08.5789631Z 14   --> $DIR/validate_uninhabited_zsts.rs:13:8
2020-02-23T06:24:08.5789859Z 
2020-02-23T06:24:08.5790030Z 47    |
2020-02-23T06:24:08.5790498Z 48    = note: 0-variant enums have no valid value
2020-02-23T06:24:08.5791485Z - error: aborting due to previous error
2020-02-23T06:24:08.5791806Z + error: aborting due to 2 previous errors
2020-02-23T06:24:08.5792057Z 51 
2020-02-23T06:24:08.5792558Z 52 For more information about this error, try `rustc --explain E0080`.
2020-02-23T06:24:08.5792558Z 52 For more information about this error, try `rustc --explain E0080`.
2020-02-23T06:24:08.5792864Z 53 
2020-02-23T06:24:08.5792984Z 
2020-02-23T06:24:08.5793097Z 
2020-02-23T06:24:08.5793362Z The actual stderr differed from the expected stderr.
2020-02-23T06:24:08.5794329Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/validate_uninhabited_zsts/validate_uninhabited_zsts.stderr
2020-02-23T06:24:08.5795139Z To update references, rerun the tests and pass the `--bless` flag
2020-02-23T06:24:08.5795888Z To only update this specific test, also pass `--test-args consts/const-eval/validate_uninhabited_zsts.rs`
2020-02-23T06:24:08.5796461Z error: 1 errors occurred comparing output.
2020-02-23T06:24:08.5796741Z status: exit code: 1
2020-02-23T06:24:08.5796741Z status: exit code: 1
2020-02-23T06:24:08.5798949Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/validate_uninhabited_zsts" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-eval/validate_uninhabited_zsts/auxiliary" "-A" "unused"
2020-02-23T06:24:08.5800783Z ------------------------------------------
2020-02-23T06:24:08.5800999Z 
2020-02-23T06:24:08.5801400Z ------------------------------------------
2020-02-23T06:24:08.5801660Z stderr:
---
2020-02-23T06:24:08.5804349Z 
2020-02-23T06:24:08.5804598Z warning: any use of this value will cause an error
2020-02-23T06:24:08.5805255Z   --> /checkout/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs:14:26
2020-02-23T06:24:08.5805585Z    |
2020-02-23T06:24:08.5805837Z LL | const FOO: [Empty; 3] = [foo(); 3];
2020-02-23T06:24:08.5806622Z    |                          |
2020-02-23T06:24:08.5806960Z    |                          referenced constant has errors
2020-02-23T06:24:08.5807231Z    |
2020-02-23T06:24:08.5807454Z note: lint level defined here
---
2020-02-23T06:24:08.5808987Z 
2020-02-23T06:24:08.5809262Z error[E0080]: it is undefined behavior to use this value
2020-02-23T06:24:08.5809907Z   --> /checkout/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs:17:1
2020-02-23T06:24:08.5810244Z    |
2020-02-23T06:24:08.5810632Z LL | const BAR: [Empty; 3] = [unsafe { std::mem::transmute(()) }; 3];
2020-02-23T06:24:08.5811272Z    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type validation failed: encountered a value of an uninhabited type
2020-02-23T06:24:08.5811753Z    |
2020-02-23T06:24:08.5812708Z    = note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
2020-02-23T06:24:08.5813750Z warning: the type `!` does not permit zero-initialization
2020-02-23T06:24:08.5814417Z   --> /checkout/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs:5:14
2020-02-23T06:24:08.5814746Z    |
2020-02-23T06:24:08.5815012Z LL |     unsafe { std::mem::transmute(()) }
2020-02-23T06:24:08.5815012Z LL |     unsafe { std::mem::transmute(()) }
2020-02-23T06:24:08.5815351Z    |              ^^^^^^^^^^^^^^^^^^^^^^^
2020-02-23T06:24:08.5815613Z    |              |
2020-02-23T06:24:08.5815942Z    |              this code causes undefined behavior when executed
2020-02-23T06:24:08.5816512Z    |              help: use `MaybeUninit<T>` instead, and only call `assume_init` after initialization is done
2020-02-23T06:24:08.5816919Z    |
2020-02-23T06:24:08.5817177Z    = note: `#[warn(invalid_value)]` on by default
2020-02-23T06:24:08.5817548Z    = note: The never type (`!`) has no valid value
2020-02-23T06:24:08.5818273Z warning: the type `Empty` does not permit zero-initialization
2020-02-23T06:24:08.5818932Z   --> /checkout/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs:17:35
2020-02-23T06:24:08.5819272Z    |
2020-02-23T06:24:08.5819272Z    |
2020-02-23T06:24:08.5819608Z LL | const BAR: [Empty; 3] = [unsafe { std::mem::transmute(()) }; 3];
2020-02-23T06:24:08.5820393Z    |                                   |
2020-02-23T06:24:08.5820787Z    |                                   this code causes undefined behavior when executed
2020-02-23T06:24:08.5821407Z    |                                   help: use `MaybeUninit<T>` instead, and only call `assume_init` after initialization is done
2020-02-23T06:24:08.5821839Z    |
2020-02-23T06:24:08.5821839Z    |
2020-02-23T06:24:08.5822290Z    = note: 0-variant enums have no valid value
2020-02-23T06:24:08.5822744Z error: aborting due to 2 previous errors
2020-02-23T06:24:08.5822943Z 
2020-02-23T06:24:08.5823438Z For more information about this error, try `rustc --explain E0080`.
2020-02-23T06:24:08.5823691Z 
---
2020-02-23T06:24:08.5826786Z 10 
2020-02-23T06:24:08.5826924Z 
2020-02-23T06:24:08.5827039Z 
2020-02-23T06:24:08.5827284Z The actual stderr differed from the expected stderr.
2020-02-23T06:24:08.5828135Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/generator/async-generator-issue-67158/async-generator-issue-67158.stderr
2020-02-23T06:24:08.5828918Z To update references, rerun the tests and pass the `--bless` flag
2020-02-23T06:24:08.5829629Z To only update this specific test, also pass `--test-args generator/async-generator-issue-67158.rs`
2020-02-23T06:24:08.5830185Z error: 1 errors occurred comparing output.
2020-02-23T06:24:08.5830477Z status: exit code: 1
2020-02-23T06:24:08.5830477Z status: exit code: 1
2020-02-23T06:24:08.5832794Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/generator/async-generator-issue-67158.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/generator/async-generator-issue-67158" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/generator/async-generator-issue-67158/auxiliary" "-A" "unused"
2020-02-23T06:24:08.5834739Z ------------------------------------------
2020-02-23T06:24:08.5834942Z 
2020-02-23T06:24:08.5835354Z ------------------------------------------
2020-02-23T06:24:08.5835597Z stderr:
2020-02-23T06:24:08.5835597Z stderr:
2020-02-23T06:24:08.5836022Z ------------------------------------------
2020-02-23T06:24:08.5836365Z error[E0727]: `async` generators are not yet supported
2020-02-23T06:24:08.5837010Z   --> /checkout/src/test/ui/generator/async-generator-issue-67158.rs:5:13
2020-02-23T06:24:08.5837347Z    |
2020-02-23T06:24:08.5837700Z LL |     async { yield print!(":C") }; //~ ERROR `async` generators are not yet supported
2020-02-23T06:24:08.5838378Z 
2020-02-23T06:24:08.5838611Z error: aborting due to previous error
2020-02-23T06:24:08.5838804Z 
2020-02-23T06:24:08.5838918Z 
---
2020-02-23T06:24:08.5880355Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2020-02-23T06:24:08.5880872Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-02-23T06:24:08.5884853Z 
2020-02-23T06:24:08.5885187Z 
2020-02-23T06:24:08.5889756Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-23T06:24:08.5893075Z 
2020-02-23T06:24:08.5893319Z 
2020-02-23T06:24:08.5898425Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-02-23T06:24:08.5898825Z Build completed unsuccessfully in 0:59:30
2020-02-23T06:24:08.5898825Z Build completed unsuccessfully in 0:59:30
2020-02-23T06:24:08.5945175Z == clock drift check ==
2020-02-23T06:24:08.5994096Z   local time: Sun Feb 23 06:24:08 UTC 2020
2020-02-23T06:24:08.8618464Z   network time: Sun, 23 Feb 2020 06:24:08 GMT
2020-02-23T06:24:08.8618922Z == end clock drift check ==
2020-02-23T06:24:09.3251730Z 
2020-02-23T06:24:09.3331941Z ##[error]Bash exited with code '1'.
2020-02-23T06:24:09.3405248Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-23T06:24:09.3412833Z ==============================================================================
2020-02-23T06:24:09.3413575Z Task         : Get sources
2020-02-23T06:24:09.3414315Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-23T06:27:02Z

💔 Test failed - checks-azure

Mark-Simulacrum · 2020-02-23T22:44:56Z

@bors r+

bors · 2020-02-23T22:44:57Z

📌 Commit a7629882db0827e8a8794901c934f7604c806a1d has been approved by Mark-Simulacrum

bors · 2020-02-23T23:35:28Z

⌛ Testing commit a7629882db0827e8a8794901c934f7604c806a1d with merge 9dd848ce0ee01e4bb7a43caded1b5855c05858f4...

rust-highfive · 2020-02-24T00:30:37Z

The job i686-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-24T00:29:11.6419910Z failures:
2020-02-24T00:29:11.6426270Z 
2020-02-24T00:29:11.6427630Z ---- [ui] ui/consts/const-eval/validate_uninhabited_zsts.rs stdout ----
2020-02-24T00:29:11.6428320Z 
2020-02-24T00:29:11.6429890Z error: /Users/runner/runners/2.165.0/work/1/s/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs:5: unexpected error: '5:14: 5:37: evaluation of constant value failed [E0080]'
2020-02-24T00:29:11.6430820Z 
2020-02-24T00:29:11.6432370Z error: /Users/runner/runners/2.165.0/work/1/s/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs:14: unexpected warning: '14:26: 14:31: any use of this value will cause an error [const_err]'
2020-02-24T00:29:11.6434760Z error: /Users/runner/runners/2.165.0/work/1/s/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs:5: expected warning not found: any use of this value will cause an error [const_err]
2020-02-24T00:29:11.6435650Z 
2020-02-24T00:29:11.6436260Z error: 2 unexpected errors found, 1 expected errors not found
2020-02-24T00:29:11.6436920Z status: exit code: 1
2020-02-24T00:29:11.6436920Z status: exit code: 1
2020-02-24T00:29:11.6440030Z command: "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.165.0/work/1/s/src/test/ui/consts/const-eval/validate_uninhabited_zsts.rs" "-Zthreads=1" "--target=i686-apple-darwin" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/test/ui/consts/const-eval/validate_uninhabited_zsts" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/test/ui/consts/const-eval/validate_uninhabited_zsts/auxiliary" "-A" "unused"
2020-02-24T00:29:11.6443170Z     Error {
2020-02-24T00:29:11.6443710Z         line_num: 5,
2020-02-24T00:29:11.6444360Z         kind: Some(
2020-02-24T00:29:11.6444950Z             Error,
2020-02-24T00:29:11.6444950Z             Error,
2020-02-24T00:29:11.6445670Z         ),
2020-02-24T00:29:11.6446410Z         msg: "5:14: 5:37: evaluation of constant value failed [E0080]",
2020-02-24T00:29:11.6447580Z     Error {
2020-02-24T00:29:11.6448120Z         line_num: 14,
2020-02-24T00:29:11.6448680Z         kind: Some(
2020-02-24T00:29:11.6449240Z             Warning,
2020-02-24T00:29:11.6449240Z             Warning,
2020-02-24T00:29:11.6449760Z         ),
2020-02-24T00:29:11.6450440Z         msg: "14:26: 14:31: any use of this value will cause an error [const_err]",
2020-02-24T00:29:11.6451580Z ]
2020-02-24T00:29:11.6452020Z 
2020-02-24T00:29:11.6452560Z not found errors (from test file): [
2020-02-24T00:29:11.6453150Z     Error {
---
2020-02-24T00:29:11.6465090Z 
2020-02-24T00:29:11.6516040Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2020-02-24T00:29:11.6536320Z 
2020-02-24T00:29:11.6536710Z 
2020-02-24T00:29:11.6542760Z command did not execute successfully: "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/stage2/lib" "--run-lib-path" "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "--rustc-path" "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "--src-base" "/Users/runner/runners/2.165.0/work/1/s/src/test/ui" "--build-base" "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/test/ui" "--stage-id" "stage2-i686-apple-darwin" "--mode" "ui" "--target" "i686-apple-darwin" "--host" "i686-apple-darwin" "--llvm-filecheck" "/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.165.0/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.41.1-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-02-24T00:29:11.6547110Z 
2020-02-24T00:29:11.6547230Z 
2020-02-24T00:29:11.6548990Z failed to run: /Users/runner/runners/2.165.0/work/1/s/build/bootstrap/debug/bootstrap test
2020-02-24T00:29:11.6549470Z Build completed unsuccessfully in 0:48:46
2020-02-24T00:29:11.6549470Z Build completed unsuccessfully in 0:48:46
2020-02-24T00:29:11.6615430Z == clock drift check ==
2020-02-24T00:29:11.6679900Z   local time: Mon Feb 24 00:29:11 UTC 2020
2020-02-24T00:29:11.7254360Z   network time: Mon, 24 Feb 2020 00:29:11 GMT
2020-02-24T00:29:11.7256160Z == end clock drift check ==
2020-02-24T00:29:11.7296820Z 
2020-02-24T00:29:11.7378990Z ##[error]Bash exited with code '1'.
2020-02-24T00:29:11.7459270Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-02-24T00:29:11.7466450Z ==============================================================================
2020-02-24T00:29:11.7466910Z Task         : Get sources
2020-02-24T00:29:11.7467340Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-24T00:30:47Z

💔 Test failed - checks-azure

Mark-Simulacrum · 2020-02-24T01:04:44Z

@bors r+

Gah, forgot to update the .rs file as well...

bors · 2020-02-24T01:04:46Z

📌 Commit 53139c5 has been approved by Mark-Simulacrum

bors · 2020-02-24T03:43:37Z

⌛ Testing commit 53139c5 with merge ded0270...

bors · 2020-02-24T07:00:00Z

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing ded0270 to stable...

Mark-Simulacrum and others added 3 commits February 21, 2020 15:47

1.41.1 release

1059a86

rustfmt relevant files

00b07c6

Revert "Remove checked_add in Layout::repeat"

aaa142a

This fixes a a segfault in safe code, a stable regression. Reported in \rust-lang#69225. This reverts commit a983e05. Also adds a test for the expected behaviour.

Mark-Simulacrum force-pushed the stable-next branch from f72e401 to 95beef7 Compare February 21, 2020 22:34

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 21, 2020

estebank and others added 6 commits February 22, 2020 11:01

Do not ICE when encountering yield inside async block

a978a97

Correct ICE caused by macros generating invalid spans.

bb392dc

Demonstrate final build-override syntax

2427a49

Resolve long compile times when evaluating always valid constants

c5b841c

This extends the existing logic which skips validating every integer or floating point number type to also skip validating empty structs because they are also trivially valid. Fixes rust-lang#67539

Check Copy lifetimes bounds when copying from a projection

6195b60

Check types of statics in MIR typeck

8f92102

Mark-Simulacrum force-pushed the stable-next branch from 95beef7 to 8f92102 Compare February 22, 2020 16:01

Clean out some default-installed directories

6d4e588

This helps us have enough disk space for our builders to be able to complete successfully. For now, the choices are ad-hoc and 'definitely not needed'. This should never fail the build, as everything our build needs should be inside Docker.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 23, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2020

Correct stderr output for failing tests

53139c5

Mark-Simulacrum force-pushed the stable-next branch from a762988 to 53139c5 Compare February 24, 2020 01:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 24, 2020

bors merged commit ded0270 into rust-lang:stable Feb 24, 2020

dfyz mentioned this pull request Feb 24, 2020

Memory unsafety problem in safe Rust #69225

Closed

[stable] 1.41.1 release #69359

[stable] 1.41.1 release #69359

Uh oh!

Conversation

Mark-Simulacrum commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mark-Simulacrum commented Feb 21, 2020

Uh oh!

bors commented Feb 21, 2020

Uh oh!

rust-highfive commented Feb 21, 2020

Uh oh!

bors commented Feb 21, 2020

Uh oh!

Mark-Simulacrum commented Feb 22, 2020

Uh oh!

bors commented Feb 22, 2020

Uh oh!

bors commented Feb 22, 2020

Uh oh!

Mark-Simulacrum commented Feb 23, 2020

Uh oh!

bors commented Feb 23, 2020

Uh oh!

bors commented Feb 23, 2020

Uh oh!

rust-highfive commented Feb 23, 2020

Uh oh!

bors commented Feb 23, 2020

Uh oh!

Mark-Simulacrum commented Feb 23, 2020

Uh oh!

bors commented Feb 23, 2020

Uh oh!

bors commented Feb 23, 2020

Uh oh!

rust-highfive commented Feb 24, 2020

Uh oh!

bors commented Feb 24, 2020

Uh oh!

Mark-Simulacrum commented Feb 24, 2020

Uh oh!

bors commented Feb 24, 2020

Uh oh!

bors commented Feb 24, 2020

Uh oh!

bors commented Feb 24, 2020

Uh oh!

Uh oh!

Mark-Simulacrum commented Feb 21, 2020 •

edited

Loading