-
Notifications
You must be signed in to change notification settings - Fork 13.4k
--explain
disambiguates no long description and invalid error codes
#69442
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Some changes occurred in diagnostic error codes |
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
r? @Mark-Simulacrum cc @rust-lang/wg-diagnostics |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!
I've added some comments -- I didn't have time to go back through a second time to make sure they're all consistent, but the latter comments are the "more correct" ones as I gained a better understanding of the code myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks for doing it!
--explain
disamiguates no long description and invalid error codes--explain
disambiguates no long description and invalid error codes
Please also squash all the commits down into one in your next push, and I think this'll be ready to go! |
@bors r+ |
📌 Commit 89cadeddb17ce788401f4f854158e94f755da0ff has been approved by |
☔ The latest upstream changes (presumably #69555) made this pull request unmergeable. Please resolve the merge conflicts. |
@jakevossen5 you will need to rebase on top of a recent master. |
@estebank should be good now! |
Commits need to be squashed into one here it looks like but otherwise this is good to go. |
@Mark-Simulacrum should be good now, thank you! |
@bors r+ Thanks! |
📌 Commit 5f3ffee has been approved by |
☀️ Test successful - checks-azure |
Closes #44710
First code contribution here, so feedback is very much appreciated!
cc @zackmdavis
cc @Mark-Simulacrum