simplify boolean expressions #69569
Merged
simplify boolean expressions #69569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
approved these changes
Feb 29, 2020
matthiaskrgr
force-pushed
the
nonminimal_bool
branch
from
4a622c6 to
435eee0
Compare
JohnTitor
reviewed
Feb 29, 2020
| @@ -568,7 +568,7 @@ impl<T: Ord> BinaryHeap<T> { | |||
| while child < end { | |||
| let right = child + 1; | |||
| // compare with the greater of the two children | |||
| if right < end && !(hole.get(child) > hole.get(right)) { | |||
| if right < end && (hole.get(child) <= hole.get(right)) { | |||
There was a problem hiding this comment.
Same here, unnecessary parentheses.
There was a problem hiding this comment.
I guess the unused-parens lint only warns on outermost parenthesis?
matthiaskrgr
force-pushed
the
nonminimal_bool
branch
from
435eee0 to
56a3da3
Compare
|
@rustbot modify labels to +S-waiting-on-review |
|
@bors r=mark-Simulacrum rollup |
|
📌 Commit 56a3da3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 1, 2020
Rollup of 7 pull requests Successful merges: - #69504 (Use assert_ne in hash tests) - #69554 (Cleanup e0374) - #69568 (Clarify explanation of Vec<T> 'fn resize') - #69569 (simplify boolean expressions) - #69577 (Clean up E0375 explanation) - #69598 (rustdoc: HTML escape crate version) - #69607 (Clean up E0376 explanation) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.