-
Notifications
You must be signed in to change notification settings - Fork 13.3k
tidy: replace make check
with ./x.py test
in documentation
#69603
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
re: #69603 (comment) @petrochenkov Here is what I see with
|
r? @petrochenkov -- I didn't know about the shortcut either, so clearly I'm not the best to review. :) |
This is not surprising, given that |
|
Thanks Vadim!
Apologies. I think that I misread the earlier comment.
I will update the test help and let you know when it is available. |
Added in 9f734c9
I believe that I addressed all of your suggestions. Please let me know if there are any other locations in this repository where this information might be of use. |
rust-lang/rustc-dev-guide#607 adds the same recommendation to the |
@bors r+ rollup |
📌 Commit c60d581 has been approved by |
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
Rollup of 8 pull requests Successful merges: - #66472 (--show-coverage json) - #69603 (tidy: replace `make check` with `./x.py test` in documentation) - #69760 (Improve expression & attribute parsing) - #69828 (fix memory leak when vec::IntoIter panics during drop) - #69850 (panic_bounds_check: use caller_location, like PanicFnLangItem) - #69876 (Add long error explanation for E0739) - #69888 ([Miri] Use a session variable instead of checking for an env var always) - #69893 (librustc_codegen_llvm: Use slices instead of 0-terminated strings) Failed merges: r? @ghost
This PR includes a minor documentation update for tidy. It replaces the
make check
approach with./x.py test
and describes how to execute the tidy checks (only) with./x.py test src/tools/tidy
./x.py test tidy
.