Skip to content

Correctly reject TraitCandidate in all cases #69717

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Mar 4, 2020

Follow up to #69255, addresses #69629.

When self.select_trait_candidate(trait_ref) returned Err(_), result wasn't being set to NoMatch, causing invalid methods to be selected.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2020
@Centril
Copy link
Contributor

Centril commented Mar 4, 2020

It would be great if we could add a regression test.

@estebank
Copy link
Contributor Author

estebank commented Mar 4, 2020

Couldn't build a minified case but it should be easy enough. I wanted to merge asap to close the hole early before people start relying on this by accident.

@varkor
Copy link
Member

varkor commented Mar 4, 2020

r? @varkor @bors r+ p=1
Let's leave the original issue open as E-needstest, though.

@bors
Copy link
Collaborator

bors commented Mar 4, 2020

📌 Commit 8a32729 has been approved by varkor

@rust-highfive rust-highfive assigned varkor and unassigned matthewjasper Mar 4, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2020
@bors
Copy link
Collaborator

bors commented Mar 5, 2020

⌛ Testing commit 8a32729 with merge 1e17969...

@bors
Copy link
Collaborator

bors commented Mar 5, 2020

☀️ Test successful - checks-azure
Approved by: varkor
Pushing 1e17969 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 5, 2020
@bors bors merged commit 1e17969 into rust-lang:master Mar 5, 2020
@estebank estebank deleted the correctly-probe branch November 9, 2023 05:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants