Ensure that validity only raises validity errors #69762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Mar 6, 2020
bjorn3
reviewed
Mar 6, 2020
RalfJung
added
the
S-waiting-on-review
oli-obk
requested changes
Mar 6, 2020
|
@bors r+ |
|
📌 Commit b088ef61837b4ee3a407d2e86041574116635b17 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
RalfJung
force-pushed
the
validity-errors
branch
from
b088ef6 to
0bc4277
Compare
|
I rebased this on top of #69646 (as they conflict quite badly). @bors r- |
bors
added
S-waiting-on-author
RalfJung
added
S-blocked
bors
added
S-waiting-on-author
RalfJung
force-pushed
the
validity-errors
branch
from
0bc4277 to
72de651
Compare
RalfJung
force-pushed
the
validity-errors
branch
from
72de651 to
ed3014a
Compare
|
All right, parent PR landed. Rebased and good to go. |
|
📌 Commit ed3014a has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
Merged
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2020
Ensure that validity only raises validity errors For now, only as a debug-assertion (similar to const-prop detecting errors that allocate). Now includes rust-lang#69646. [Relative diff](RalfJung/rust@layout-visitor...RalfJung:validity-errors). r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2020
Ensure that validity only raises validity errors For now, only as a debug-assertion (similar to const-prop detecting errors that allocate). Now includes rust-lang#69646. [Relative diff](RalfJung/rust@layout-visitor...RalfJung:validity-errors). r? @oli-obk
bors
added a commit
that referenced
this pull request
Mar 9, 2020
Rollup of 6 pull requests Successful merges: - #69201 (Permit attributes on 'if' expressions) - #69402 (Extend search) - #69519 ( Don't use static crt by default when build proc-macro) - #69685 (unix: Don't override existing SIGSEGV/BUS handlers) - #69762 (Ensure that validity only raises validity errors) - #69779 (librustc_codegen_llvm: Use slices in preference to 0-terminated strings) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2020
Ensure that validity only raises validity errors For now, only as a debug-assertion (similar to const-prop detecting errors that allocate). Now includes rust-lang#69646. [Relative diff](RalfJung/rust@layout-visitor...RalfJung:validity-errors). r? @oli-obk
bors
added a commit
that referenced
this pull request
Mar 9, 2020
Rollup of 6 pull requests Successful merges: - #69201 (Permit attributes on 'if' expressions) - #69685 (unix: Don't override existing SIGSEGV/BUS handlers) - #69762 (Ensure that validity only raises validity errors) - #69779 (librustc_codegen_llvm: Use slices in preference to 0-terminated strings) - #69801 (rustc_parse: Remove `Parser::normalized(_prev)_token`) - #69842 (Add more regression tests) Failed merges: r? @ghost
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Mar 9, 2020
rustup: adjust error message This is the Miri side of rust-lang/rust#69762
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 17, 2020
Miri error reform Some time ago we started moving Miri errors into a few distinct categories, but we never classified all the old errors. That's what this PR does. ~~This is on top of rust-lang#69762; [relative diff](RalfJung/rust@validity-errors...RalfJung:miri-error-cleanup).~~ r? @oli-obk Fixes rust-lang/const-eval#4
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 18, 2020
Miri error reform Some time ago we started moving Miri errors into a few distinct categories, but we never classified all the old errors. That's what this PR does. ~~This is on top of rust-lang#69762; [relative diff](RalfJung/rust@validity-errors...RalfJung:miri-error-cleanup).~~ r? @oli-obk Fixes rust-lang/const-eval#4
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 18, 2020
Miri error reform Some time ago we started moving Miri errors into a few distinct categories, but we never classified all the old errors. That's what this PR does. ~~This is on top of rust-lang#69762; [relative diff](RalfJung/rust@validity-errors...RalfJung:miri-error-cleanup).~~ r? @oli-obk Fixes rust-lang/const-eval#4
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 18, 2020
Miri error reform Some time ago we started moving Miri errors into a few distinct categories, but we never classified all the old errors. That's what this PR does. ~~This is on top of rust-lang#69762; [relative diff](RalfJung/rust@validity-errors...RalfJung:miri-error-cleanup).~~ r? @oli-obk Fixes rust-lang/const-eval#4
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, only as a debug-assertion (similar to const-prop detecting errors that allocate).
Now includes #69646.
Relative diff.
r? @oli-obk