Skip to content

test(bindings_after_at): add dynamic drop tests for bindings_after_at #69810

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

thekuom
Copy link
Contributor

@thekuom thekuom commented Mar 7, 2020

Fixes #67523.
Working towards #65490.

@jonas-schievink jonas-schievink added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2020
@jonas-schievink
Copy link
Contributor

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned nikomatsakis Mar 7, 2020
@Centril Centril added the F-bindings_after_at `#![feature(bindings_after_at)]` label Mar 8, 2020
@Centril
Copy link
Contributor

Centril commented Mar 8, 2020

Thanks! @bors r+ & cc @matthewjasper @pnkfelix for awareness.

@bors
Copy link
Collaborator

bors commented Mar 8, 2020

📌 Commit 2e88bec has been approved by Centril

@bors
Copy link
Collaborator

bors commented Mar 8, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 8, 2020
…s-bindings-after-at, r=Centril

test(bindings_after_at): add dynamic drop tests for bindings_after_at

Fixes rust-lang#67523.
Working towards rust-lang#65490.
bors added a commit that referenced this pull request Mar 8, 2020
Rollup of 8 pull requests

Successful merges:

 - #69422 (Remove use of `unwrap()` from save-analysis)
 - #69548 (Turn trailing tokens in `assert!()` into hard errors)
 - #69561 (Clean up unstable book)
 - #69599 (check_binding_alt_eq_ty: improve precision wrt. `if let`)
 - #69641 (Update books)
 - #69776 (Fix & test leak of some BTreeMap nodes on panic during `into_iter`)
 - #69805 (resolve: Modernize some naming)
 - #69810 (test(bindings_after_at): add dynamic drop tests for bindings_after_at)

Failed merges:

r? @ghost
@bors bors merged commit 49c82d1 into rust-lang:master Mar 8, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
F-bindings_after_at `#![feature(bindings_after_at)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit & Harden run-pass tests for #![feature(bindings_after_at)]
5 participants