Skip to content

submodules: update clippy from 8485d40a to d556bb73 #70020

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Mar 15, 2020

Changes:

    rustup https://github.com/rust-lang/rust/pull/68944
    rustup https://github.com/rust-lang/rust/pull/69589/
    Rustup to rust-lang/rust#69076
    Don't convert Path to lossy str
    Use `into_path`
    Use pattern matching instead of manually checking condition
    Fix typo
    Remove git2 dependency.
    Document that wildcard_imports doesn't warn about `use ...::prelude::*;`
    Change changelog formatting
    Update changelog_update doc to reflect the actual ordering of the changelog
    Update CHANGELOG.md

Fixes #70007

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2020
@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 16, 2020

📌 Commit be7519740de8ca53d87ce77b9c22231d51028766 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2020
@ehuss
Copy link
Contributor

ehuss commented Mar 16, 2020

@bors p=1
Unblocks cargo, and fixes toolstate.

@matthiaskrgr
Copy link
Member Author

This is currently blocked on rust-lang/rust-clippy#5321

@Dylan-DPC-zz
Copy link

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2020
@matthiaskrgr matthiaskrgr changed the title submodules: update clippy from 8485d40a to 8fd7e31d submodules: update clippy from 8485d40a to d556bb73 Mar 16, 2020
Changes:
````
rustup rust-lang#69738
rustup rust-lang#68944
Make use of `or_patterns` feature
rustup rust-lang#69589
Rustup to rust-lang#69076
Don't convert Path to lossy str
Use `into_path`
Use pattern matching instead of manually checking condition
Fix typo
Remove git2 dependency.
Document that wildcard_imports doesn't warn about `use ...::prelude::*;`
Change changelog formatting
Update changelog_update doc to reflect the actual ordering of the changelog
Update CHANGELOG.md
````

Fixes rust-lang#70007
@matthiaskrgr
Copy link
Member Author

Should be in sync again.

@ehuss
Copy link
Contributor

ehuss commented Mar 16, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 16, 2020

📌 Commit 7e2ebb0 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2020
@Manishearth
Copy link
Member

@bors p=20

@bors
Copy link
Collaborator

bors commented Mar 17, 2020

⌛ Testing commit 7e2ebb0 with merge ae5b641...

@bors
Copy link
Collaborator

bors commented Mar 18, 2020

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing ae5b641 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2020
@bors bors merged commit ae5b641 into rust-lang:master Mar 18, 2020
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #70020!

Tested on commit ae5b641.
Direct link to PR: #70020

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 18, 2020
Tested on commit rust-lang/rust@ae5b641.
Direct link to PR: <rust-lang/rust#70020>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
@matthiaskrgr matthiaskrgr deleted the submodule_upd branch March 18, 2020 01:46
@matthiaskrgr
Copy link
Member Author

It barely missed the nightly cutoff 😢

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#69076
7 participants