Fix ICE caused by truncating a negative ZST enum discriminant #70126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Mar 19, 2020
RalfJung
reviewed
Mar 19, 2020
RalfJung
reviewed
Mar 19, 2020
RalfJung
reviewed
Mar 19, 2020
This comment has been minimized.
This comment has been minimized.
wesleywiser
force-pushed
the
fix_miri_ice_neg_zst_enum_discr
branch
from
61ab908 to
4b9cbe0
Compare
eddyb
approved these changes
Mar 20, 2020
This comment has been minimized.
This comment has been minimized.
wesleywiser
force-pushed
the
fix_miri_ice_neg_zst_enum_discr
branch
from
4b9cbe0 to
1f39b2e
Compare
RalfJung
reviewed
Mar 21, 2020
wesleywiser
force-pushed
the
fix_miri_ice_neg_zst_enum_discr
branch
from
1f39b2e to
96bbd1c
Compare
|
@bors r=RalfJung,eddyb |
|
📌 Commit 96bbd1c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#70003 (symbol_names: treat ReifyShim like VtableShim.) - rust-lang#70051 (Allow `hir().find` to return `None`) - rust-lang#70126 (Fix ICE caused by truncating a negative ZST enum discriminant) - rust-lang#70197 (For issue 53957: revise unit test to focus on underlying bug of 23076.) - rust-lang#70215 (ast: Compress `AttrId` from `usize` to `u32`) - rust-lang#70218 (Fix deprecated Error.description() usage in docs) - rust-lang#70228 (Remove CARGO_BUILD_TARGET from bootstrap.py) - rust-lang#70231 (Add explanation message for E0224) - rust-lang#70232 (Tweak wording for std::io::Read::read function) - rust-lang#70238 (Add a test for out-of-line module passed through a proc macro) Failed merges: r? @ghost
wesleywiser
added
beta-nominated
|
Discussed in T-compiler meeting. Declining to beta-backport. |
pnkfelix
removed
the
beta-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70114
r? @oli-obk or @RalfJung