Skip to content

doc: Add quote to .init_array #70145

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 20, 2020
Merged

doc: Add quote to .init_array #70145

merged 1 commit into from
Mar 20, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Mar 19, 2020

The current formatting is not good without quotes:
without-quote

@rust-highfive
Copy link
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Mar 19, 2020

r? @joshtriplett as reviewer of #66547.

@Dylan-DPC-zz
Copy link

Wouldn't it be better to use ` instead of quotes?

@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@tesuji
Copy link
Contributor Author

tesuji commented Mar 19, 2020

Wouldn't it be better to use ` instead of quotes?

I don't have strong opinion on this. But I vaguely remembered one Rust member
prefer to using " for non code things.

Here the doc after using backtick `: tick

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 19, 2020

📌 Commit 2c38ecf has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Mar 19, 2020

Just to be sure: Currently I still use double quote ("). Is this OK to you?

@Dylan-DPC-zz
Copy link

Yes I'm aware. It is fine no worries

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 19, 2020
doc: Add quote to .init_array

The current formatting is not good without quotes:
![without-quote](https://i.imgur.com/RkIm4cr.png)
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2020
Rollup of 9 pull requests

Successful merges:

 - rust-lang#69618 (Clarify the relationship between `forget()` and `ManuallyDrop`.)
 - rust-lang#69768 (Compute the correct layout for variants of uninhabited enums)
 - rust-lang#69935 (codegen/mir: support polymorphic `InstanceDef`s)
 - rust-lang#70103 (Clean up E0437 explanation)
 - rust-lang#70131 (Add regression test for TAIT lifetime inference (issue rust-lang#55099))
 - rust-lang#70133 (remove unused imports)
 - rust-lang#70145 (doc: Add quote to .init_array)
 - rust-lang#70146 (Clean up e0438 explanation)
 - rust-lang#70150 (triagebot.toml: accept cleanup-crew)

Failed merges:

r? @ghost
@bors bors merged commit d6ebf21 into rust-lang:master Mar 20, 2020
@tesuji tesuji deleted the patch-1 branch March 21, 2020 01:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants