Skip to content

Removing internal iterators, part 3 #7032

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 21 commits into from
Jun 10, 2013
Merged

Conversation

huonw
Copy link
Member

@huonw huonw commented Jun 9, 2013

Continuation of #7015, and #6995.

Rewrites the character-based each_split functions in str to use an iterator, removes a few redundant methods, and replaces all uses of len, is_empty and slice functions with the methods (and deletes the the functions).

Update: Ok, this has turned into a major makeover for str, turning a lot of functions into methods, and removing redundant ones. Each commit is essentially a single such change.

(Unscientific benchmarks suggest that the external split_iter is approximately 10% faster than the internal one. I'm not quite sure why this would be true.)

(@thestinger is probably interested in this.)

bors added a commit that referenced this pull request Jun 10, 2013
Continuation of #7015, and #6995.

Rewrites the character-based `each_split` functions in `str` to use an iterator, removes a few redundant methods, and replaces all uses of `len`, `is_empty` and `slice` functions with the methods (and deletes the the functions).

Update: Ok, this has turned into a major makeover for `str`, turning a lot of functions into methods, and removing redundant ones. Each commit is essentially a single such change.

(Unscientific benchmarks suggest that the external `split_iter` is approximately 10% faster than the internal one. I'm not quite sure why this would be true.)

(@thestinger is probably interested in this.)
@bors bors closed this Jun 10, 2013
@bors bors merged commit e8782ee into rust-lang:incoming Jun 10, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 22, 2021
Fix FP in `wrong_self_convention` lint

Previously, this lint didn't check into impl block when it was implementing a trait.
Recent improvements (rust-lang#6924) have moved this check and some impl blocks are now checked but they shouldn't, such as in rust-lang#7032.

Fixes rust-lang#7032

changelog: Fix FP when not taking `self` in impl block for `wrong_self_convention` lint
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants