Skip to content

parse_and_disallow_postfix_after_cast: account for ExprKind::Err. #70556

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

parse_and_disallow_postfix_after_cast: account for ExprKind::Err. #70556

merged 1 commit into from
Apr 1, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 30, 2020

Fixes #70552.

r? @estebank
cc @daboross

@Centril Centril added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 30, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2020
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 31, 2020

📌 Commit 96d7353 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 31, 2020
@Dylan-DPC
Rollup merge of rust-lang#70556 - Centril:fix-70552, r=estebank
f2d08ab 
parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`.

Fixes rust-lang#70552.

r? @estebank
cc @daboross
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 31, 2020
Closed
@Dylan-DPC-zz
Copy link

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2020
@Centril
Copy link
Contributor Author

Centril commented Mar 31, 2020

Wrong PR @Dylan-DPC... :) @bors r=estebank

@bors
Copy link
Collaborator

bors commented Mar 31, 2020

📌 Commit 96d7353 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2020
@Dylan-DPC-zz
Copy link

@bors r=estebank

@bors
Copy link
Collaborator

bors commented Mar 31, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 31, 2020

📌 Commit 96d7353 has been approved by estebank

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 31, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2020
@bors
Auto merge of rust-lang#70638 - Dylan-DPC:rollup-2tgfxjt, r=Dylan-DPC
58dd1ce 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#68770 (BTreeMap/BTreeSet: implement drain_filter )
 - rust-lang#70081 (add `unused_braces` lint)
 - rust-lang#70556 (parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`.)
 - rust-lang#70605 (Add missing -lmsvcrt on mingw after -lpthread)
 - rust-lang#70630 (Update books.)
 - rust-lang#70632 (expand vec![] to Vec::new())

Failed merges:

r? @ghost
@bors bors merged commit 81f19ec into rust-lang:master Apr 1, 2020
@Centril Centril deleted the fix-70552 branch April 1, 2020 09:27
@pnkfelix
Copy link
Member

pnkfelix commented Apr 2, 2020

discussed at today's T-compiler meeting. Accepted for beta backport.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 2, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 3, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 3, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2020
@bors
Auto merge of rust-lang#70742 - Mark-Simulacrum:beta-next, r=Mark-Sim…
4331852 
…ulacrum

[beta] backport 4 PRs

This backports the following PRs:

* parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`. rust-lang#70556
* Account for bad placeholder types in where clauses rust-lang#70294
* Fix "since" field for `Once::is_complete`'s `#[stable]` attribute rust-lang#70018
* Ensure HAS_FREE_LOCAL_NAMES is set for ReFree rust-lang#69956

All commits cherry picked cleanly.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal error: entered unreachable code: parse_dot_or_call_expr_with_ shouldn't produce this
7 participants
@Centril @estebank @bors @Dylan-DPC-zz @pnkfelix @Mark-Simulacrum @rust-highfive