Ensure LLVM is in the link path for "fulldeps" tests #70591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit c5ee425eba6a0b8c86bf6828f5452fb5c766d4eb has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- I forgot |
bors
added
S-waiting-on-author
This is a follow-up to rust-lang#70123, which added `llvm-config --libdir` to the `LIBRARY_PATH` for rustc tools. We need the same for "run-make-fulldeps" and "ui-fulldeps" tests which depend on compiler libraries, implicitly needing to link to `-lLLVM` as well.
cuviper
force-pushed
the
fulldeps-library-path
branch
from
c5ee425 to
6067315
Compare
|
@bors r=Mark-Simulacrum |
|
📌 Commit 6067315 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6067315 with merge d1b6926efee2f0921f068ee10a3f08e75a5df6d1... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 1, 2020
…rk-Simulacrum Ensure LLVM is in the link path for "fulldeps" tests This is a follow-up to rust-lang#70123, which added `llvm-config --libdir` to the `LIBRARY_PATH` for rustc tools. We need the same for "run-make-fulldeps" and "ui-fulldeps" tests which depend on compiler libraries, implicitly needing to link to `-lLLVM` as well.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#70511 (Add `-Z dump-mir-dataflow` flag for dumping dataflow results visualization) - rust-lang#70522 (Improve error messages for raw strings (rust-lang#60762)) - rust-lang#70547 (Add `can_unwind` field to `FnAbi`) - rust-lang#70591 (Ensure LLVM is in the link path for "fulldeps" tests) - rust-lang#70627 (Use place directly its copy) - rust-lang#70652 (Add git repo address to unstable book) Failed merges: - rust-lang#70634 (Remove some reexports in `rustc_middle`) r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #70123, which added
llvm-config --libdirto theLIBRARY_PATHfor rustc tools. We need the same for "run-make-fulldeps"and "ui-fulldeps" tests which depend on compiler libraries, implicitly
needing to link to
-lLLVMas well.