-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Got rid of repetitions (such as rustc_ast::ast::) in librustc_ast. #70621
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @Centril |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
4c6d667
to
b7ca0e5
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
b7ca0e5
to
5576f84
Compare
@bors r+ |
📌 Commit 5576f84 has been approved by |
☔ The latest upstream changes (presumably #70638) made this pull request unmergeable. Please resolve the merge conflicts. |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
Ping from Triage: @Lezzz any updates? |
FWIW, I'm still not sure this is an improvement. |
Reworked (simpler than rebasing it) this in #71199. Closing it. Thanks for taking the time to contribute |
rust_ast::ast => rustc_ast Rework of rust-lang#71199 which is a rework rust-lang#70621 Still working on this but just made the PR to track progress r? @Dylan-DPC
rust_ast::ast => rustc_ast Rework of rust-lang#71199 which is a rework rust-lang#70621 Still working on this but just made the PR to track progress r? @Dylan-DPC
Originally suggested by @eddyb .