Skip to content

GHA: enable running multiple try builds at the same time #70628

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

GHA: enable running multiple try builds at the same time #70628

merged 1 commit into from
Apr 2, 2020

Conversation

pietroalbini
Copy link
Member

While for auto, try and PR builds we only want the latest commit to be tested, that's not true for try builds: each commit pushed to the branch is a different PR being tested, and we want multiple PRs to be tested in parallel if there is enough demand.

Fixes #70569

@pietroalbini
ci: disable cancel-outdated-builds for the try branch
824dcd4 
While for auto, try and PR builds we only want the latest commit to be
tested, that's not true for try builds: each commit pushed to the branch
is a different PR being tested, and we want multiple PRs to be tested in
parallel if there is enough demand.

Fixes rust-lang#70569
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@pietroalbini
Copy link
Member Author

r? @Mark-Simulacrum

...unless Niko wants to review CI PRs :)

@pietroalbini
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Mar 31, 2020

⌛ Trying commit 824dcd4 with merge 50720fae71e739e39af3680c24c486ea20354c94...

@Mark-Simulacrum
Copy link
Member

...unless Niko wants to review CI PRs :)

I thought we had fixed this in highfive recently? If not, can you do so?

r=me if testing succeeds

@bors
Copy link
Collaborator

bors commented Mar 31, 2020

☀️ Try build successful - checks-azure
Build commit: 50720fae71e739e39af3680c24c486ea20354c94 (50720fae71e739e39af3680c24c486ea20354c94)

@pietroalbini
Copy link
Member Author

@bors r=Mark-Simulacrum rollup

I'll send a PR to highfive soon.

@bors
Copy link
Collaborator

bors commented Apr 1, 2020

📌 Commit 824dcd4 has been approved by Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Apr 1, 2020

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020
@Centril
Copy link
Contributor

Centril commented Apr 1, 2020

@bors rollup-

@Dylan-DPC-zz
Copy link

@bors rollup=never p=1

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

⌛ Testing commit 824dcd4 with merge 0f72ce1...

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 0f72ce1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2020
@bors bors merged commit 0f72ce1 into rust-lang:master Apr 2, 2020
@pietroalbini pietroalbini deleted the gha-multiple-tries branch December 23, 2020 23:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only one try build can happen at the same time on GHA
7 participants
@pietroalbini @rust-highfive @bors @Mark-Simulacrum @Centril @Dylan-DPC-zz @nikomatsakis