Skip to content

Remove the Ord bound that was plaguing drain_filter #70843

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

ssomers
Copy link
Contributor

@ssomers ssomers commented Apr 6, 2020

Now that #70795 made it superfluous. Also removes superfluous lifetime specifiers (at least I think they are).

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2020
@ssomers
Copy link
Contributor Author

ssomers commented Apr 6, 2020

r? @Mark-Simulacrum

@Amanieu
Copy link
Member

Amanieu commented Apr 7, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

📌 Commit 6ee7e8c has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 7, 2020
…, r=Amanieu

Remove the Ord bound that was plaguing drain_filter

Now that  rust-lang#70795 made it superfluous. Also removes superfluous lifetime specifiers (at least I think they are).
@bors
Copy link
Collaborator

bors commented Apr 7, 2020

⌛ Testing commit 6ee7e8c with merge fe93565d1bf67895f48679cc53a782b1f99d43a2...

@jonas-schievink
Copy link
Contributor

@bors treeclosed=1000

mingw builders on Azure are having issues

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2020
@Amanieu
Copy link
Member

Amanieu commented Apr 10, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#70784 (Consider methods on fundamental `impl` when method is not found on numeric type)
 - rust-lang#70843 (Remove the Ord bound that was plaguing drain_filter)
 - rust-lang#70913 (Replace "rc"/"arc" lang items with Rc/Arc diagnostic items.)
 - rust-lang#70932 (De-abuse TyKind::Error in pattern type checking)
 - rust-lang#70952 (Clean up E0511 explanation)
 - rust-lang#70964 (rustc_session CLI lint parsing: mark a temporary hack as such)
 - rust-lang#70969 (Fix JSON file_name documentation for macros.)
 - rust-lang#70975 (Fix internal doc comment nits.)

Failed merges:

r? @ghost
@bors bors merged commit 81a360f into rust-lang:master Apr 10, 2020
@ssomers ssomers deleted the btree_drain_filter_epilogue branch April 10, 2020 17:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants