Skip to content

added machine hooks to track deallocations #70962

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

RustyYato
Copy link
Contributor

This is part of rust-lang/miri#1314 in order to allow miri to show stack traces for on deallocation in order to debug use-after-free bugs

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2020
@RustyYato RustyYato marked this pull request as draft April 9, 2020 18:51
@RustyYato
Copy link
Contributor Author

cc @RalfJung

@rust-highfive

This comment has been minimized.

@RustyYato RustyYato marked this pull request as ready for review April 9, 2020 22:49
@RustyYato
Copy link
Contributor Author

@RalfJung I added the machine hook you mentioned, so after this gets merged, I can move forward in miri and add the deallocation diagnostic.

@RalfJung
Copy link
Member

r? @RalfJung

@rust-highfive rust-highfive assigned RalfJung and unassigned davidtwco Apr 10, 2020
@RustyYato RustyYato requested a review from RalfJung April 10, 2020 14:49
@RalfJung
Copy link
Member

This is looking good. :) Please squash the commits, then we can land this.

@RustyYato
Copy link
Contributor Author

@RalfJung done, thanks for the help!

@RalfJung
Copy link
Member

@bors r+
Thanks for the PR. :)

@bors
Copy link
Collaborator

bors commented Apr 10, 2020

📌 Commit 7de9511 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2020
@RalfJung
Copy link
Member

@bors rollup

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 10, 2020
…fJung

added machine hooks to track deallocations

This is part of rust-lang/miri#1314 in order to allow miri to show stack traces for on deallocation in order to debug use-after-free bugs
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 10, 2020
…fJung

added machine hooks to track deallocations

This is part of rust-lang/miri#1314 in order to allow miri to show stack traces for on deallocation in order to debug use-after-free bugs
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#69573 (tests encoding current behavior for various cases of "binding" to _.)
 - rust-lang#70881 (bootstrap: work around "unused attribute" errors in incremental stdlib rebuilds.)
 - rust-lang#70957 (Normalize MIR locals' types for generator layout computation.)
 - rust-lang#70962 (added machine hooks to track deallocations)
 - rust-lang#70982 (Normalize function signature in function casting check procedure)

Failed merges:

r? @ghost
@bors bors merged commit 8c097d5 into rust-lang:master Apr 11, 2020
@RustyYato RustyYato deleted the track-dealloc branch April 11, 2020 15:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants