Document unsafety in core::{option, hash} #71063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
cc @RalfJung |
joelpalmer
added
S-waiting-on-review
Mark-Simulacrum
added
S-waiting-on-author
Co-authored-by: Mark-Simulacrum <mark.simulacrum@gmail.com>
Co-Authored-By: Mark-Simulacrum <mark.simulacrum@gmail.com>
|
@Mark-Simulacrum If you don't have any other remark I think this is ready to be |
Mark-Simulacrum
approved these changes
Apr 23, 2020
|
@bors r+ rollup I agree! |
|
📌 Commit a694315 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 23, 2020
…Mark-Simulacrum
Document unsafety in core::{option, hash}
Helps with rust-lang#66219.
I think that the part that will need reviewing the most is the `hash/sip.rs` file.
r? @LukasKalbertodt (or someone else from the libs team)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#70845 (Make the `structural_match` error diagnostic for const generics clearer) - rust-lang#71063 (Document unsafety in core::{option, hash}) - rust-lang#71068 (Stabilize UNICODE_VERSION (feature unicode_version)) - rust-lang#71426 (fix error code in E0751.md) - rust-lang#71459 (Add leading 0x to offset in Debug fmt of Pointer) - rust-lang#71492 (Document unsafety in core::{panicking, alloc::layout, hint, iter::adapters::zip}) Failed merges: r? @ghost
tesuji
reviewed
Apr 24, 2020
| @@ -279,10 +278,13 @@ impl<S: Sip> super::Hasher for Hasher<S> { | |||
|
|
|||
| // Buffered tail is now flushed, process new input. | |||
| let len = length - needed; | |||
| let left = len & 0x7; | |||
| let left = len & 0x7; // len % 8 | |||
There was a problem hiding this comment.
I expect rustc do this optimization. Why not replace the code with len % 8?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #66219.
I think that the part that will need reviewing the most is the
hash/sip.rsfile.r? @LukasKalbertodt (or someone else from the libs team)