Skip to content

Rollup of 4 pull requests #71162

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 21 commits into from
Apr 15, 2020
Merged

Rollup of 4 pull requests #71162

merged 21 commits into from
Apr 15, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Apr 15, 2020

Successful merges:

Failed merges:

r? @ghost

RalfJung and others added 21 commits April 13, 2020 16:06
The differences if they are discovered will need to be explicitly documented
The old naming is from ancient times when there was no MSVC support.

Also `uefi_base` -> `uefi_msvc_base`.
It will inherit from `msvc_base` in a future commit, plus a GNU UEFI target is also potentially possible.
and inherit both `windows_msvc_base` and `uefi_msvc_base` from it.
…able

Some helpers functions have been introduced to deal with (buggy) cases
where either a `NodeId` or a `DefId` do not have a corresponding `HirId`.
Those cases are tracked in issue rust-lang#71104.
unit rvalue, use constant `()` instead of tuple

fixes rust-lang#70886

r? @eddyb
rustc_target: Refactor target specifications related to Windows and UEFI

- LLD support is improved.
- Code is cleaned up.
- Target specs are organized in a more hierarchical way.
- Possible issues in UWP and UEFI platforms are identified (see FIXMEs).

The code is better read per-commit.
…=eddyb

Entirely remove `DUMMY_HIR_ID`

Some helpers functions have been introduced to deal with (buggy) cases
where either a `NodeId` or a `DefId` do not have a corresponding `HirId`.
Those cases are tracked in issue rust-lang#71104.
@Centril Centril added the rollup A PR which is a rollup label Apr 15, 2020
@Centril
Copy link
Contributor Author

Centril commented Apr 15, 2020

@bors r+ p=4 rollup=never

@bors
Copy link
Collaborator

bors commented Apr 15, 2020

📌 Commit 7341cad has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 15, 2020
@bors
Copy link
Collaborator

bors commented Apr 15, 2020

⌛ Testing commit 7341cad with merge df768c5...

@bors
Copy link
Collaborator

bors commented Apr 15, 2020

☀️ Test successful - checks-azure
Approved by: Centril
Pushing df768c5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2020
@bors bors merged commit df768c5 into rust-lang:master Apr 15, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants