slice::fill: use T instead of generic arg
#71165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at #70752, this method is expected to optimize to mem set, will check if this still works when passing a reference... memset for |
|
r? @yoshuawuyts |
|
@lcnr I think there are some gotchas to always taking by reference; replied on the main thread: #70758 (comment) |
Dylan-DPC-zz
added
the
S-waiting-on-review
lcnr
changed the title
slice::fill: use &T instead of generic argslice::fill: use T instead of generic arg
|
This now uses edit: tbh I slightly misinterpreted the current state of discussion and there is still some disagreement. |
crlf0710
added
the
T-libs-api
crlf0710
added
S-waiting-on-review
|
r? @Amanieu |
|
Could you avoid cloning the last element and instead move |
|
done |
|
Can you check that the code still lowers to a |
|
Looks good |
|
@bors r+ |
|
📌 Commit 902aa62 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 3, 2020
`slice::fill`: use `T` instead of generic arg implements rust-lang#70758 (comment) As the discussion in rust-lang#70758 has shifted, I now use `T` instead of `&T`.
This was referenced May 3, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71165 (`slice::fill`: use `T` instead of generic arg) - rust-lang#71314 (Implement RFC 2523, `#[cfg(version(..))]`) - rust-lang#71542 (Implement `confusable_idents` lint.) - rust-lang#71806 (typo) - rust-lang#71813 (Decode qualifs for associated const defaults) Failed merges: r? @ghost
3 tasks
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 20, 2020
…=m-ou-se Stabilize `core::slice::fill` Tracking issue rust-lang#70758 Stabilizes the `core::slice::fill` API in Rust 1.50, adding a `memset` doc alias so people coming from C/C++ looking for this operation can find it in the docs. This API hasn't seen any changes since we changed the signature in rust-lang#71165, and it seems like the right time to propose stabilization. Thanks! r? `@m-ou-se`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 20, 2020
…=m-ou-se Stabilize `core::slice::fill` Tracking issue rust-lang#70758 Stabilizes the `core::slice::fill` API in Rust 1.50, adding a `memset` doc alias so people coming from C/C++ looking for this operation can find it in the docs. This API hasn't seen any changes since we changed the signature in rust-lang#71165, and it seems like the right time to propose stabilization. Thanks! r? ``@m-ou-se``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Dec 25, 2020
…=m-ou-se Stabilize `core::slice::fill` Tracking issue rust-lang#70758 Stabilizes the `core::slice::fill` API in Rust 1.50, adding a `memset` doc alias so people coming from C/C++ looking for this operation can find it in the docs. This API hasn't seen any changes since we changed the signature in rust-lang#71165, and it seems like the right time to propose stabilization. Thanks! r? `@m-ou-se`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #70758 (comment)
As the discussion in #70758 has shifted, I now use
Tinstead of&T.