Rollup of 5 pull requests #71190
Closed
Rollup of 5 pull requests #71190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning `Result` and vice-versa
- Change to warnings so that all lints are emitted - Expect build-pass - Change placeholder FIXME to WARN.
This ensures we get still get lints for generic contexts.
…ning `Result` and vice-versa
clippy::{filter_next,single_char_pattern,unit_arg,identity_conversion,nonminimal_bool}
…op, r=RalfJung Don't bail out before linting in generic contexts. Fixes rust-lang#69021. cc rust-lang#70017 r? @RalfJung
Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa Fixes rust-lang#71089
remove an impossible branch from check_consts All function calleess are either `FnPtr` or `FnDef`, so we can remove the alternative from check_consts and just make it ICE instead.
fix more clippy warnings
…Simulacrum Add some regression tests Closes rust-lang#24843 Closes rust-lang#28575 Closes rust-lang#54067 Closes rust-lang#67893 Closes rust-lang#68813 I'm not sure who's the best person to ask to review since Centril is taking a break now.
|
@bors r+ p=5 rollup=never |
|
📌 Commit c3c96eb has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit c3c96eb with merge 62f358e0ecba142631cc1c98f6922ddbc08740d4... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
?onOptionin fn returningResultand vice-versa #71141 (Provide better compiler output when using?onOptionin fn returningResultand vice-versa)Failed merges:
r? @ghost