Add error code for inner doc error #71214

GuillaumeGomez · 2020-04-16T19:27:16Z

rust-highfive · 2020-04-16T19:27:18Z

Some changes occurred in diagnostic error codes

rust-highfive · 2020-04-16T22:01:26Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-16T20:07:47.2934436Z ========================== Starting Command Output ===========================
2020-04-16T20:07:47.2939195Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/c8b8b42e-f355-4675-93cf-d04106a194eb.sh
2020-04-16T20:07:47.2939684Z 
2020-04-16T20:07:47.2944551Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-16T20:07:47.2965555Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71214/merge to s
2020-04-16T20:07:47.2969014Z Task         : Get sources
2020-04-16T20:07:47.2969449Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-16T20:07:47.2969710Z Version      : 1.0.0
2020-04-16T20:07:47.2969886Z Author       : Microsoft
---
2020-04-16T20:07:48.2838508Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-16T20:07:48.2844519Z ##[command]git config gc.auto 0
2020-04-16T20:07:48.2848361Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-16T20:07:48.2851403Z ##[command]git config --get-all http.proxy
2020-04-16T20:07:48.2858054Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71214/merge:refs/remotes/pull/71214/merge
---
2020-04-16T20:10:09.3460571Z  ---> f58a2bb1e753
2020-04-16T20:10:09.3462762Z Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-7       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
2020-04-16T20:10:09.3465252Z  ---> Using cache
2020-04-16T20:10:09.3465614Z  ---> d079cc6b6db8
2020-04-16T20:10:09.3468477Z Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
2020-04-16T20:10:09.3469515Z  ---> 4183ca46ee56
2020-04-16T20:10:09.3469708Z Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
2020-04-16T20:10:09.3470043Z  ---> Using cache
2020-04-16T20:10:09.3470371Z  ---> 69e7f8a2a2fb
---
2020-04-16T20:10:09.3889746Z Looks like docker image is the same as before, not uploading
2020-04-16T20:10:15.6161355Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-16T20:10:15.6534112Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-16T20:10:15.6607524Z == clock drift check ==
2020-04-16T20:10:15.6614795Z   local time: Thu Apr 16 20:10:15 UTC 2020
2020-04-16T20:10:15.8576020Z   network time: Thu, 16 Apr 2020 20:10:15 GMT
2020-04-16T20:10:15.8601584Z Starting sccache server...
2020-04-16T20:10:15.9469340Z configure: processing command line
2020-04-16T20:10:15.9469870Z configure: 
2020-04-16T20:10:15.9476059Z configure: rust.dist-src        := False
---
2020-04-16T20:15:50.0390434Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-16T20:15:51.5728807Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-16T20:15:53.2737963Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-16T20:15:54.8989844Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-16T20:16:03.8938709Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-16T20:16:06.9282362Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-16T20:16:11.5398229Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-16T20:16:15.9511898Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-16T20:16:25.6026427Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-16T20:40:24.1269491Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-16T20:40:26.0251885Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-16T20:40:28.1044629Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-16T20:40:30.7076914Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-16T20:40:41.3444448Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-16T20:40:45.3489452Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-16T20:40:50.9618979Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-16T20:40:56.8027482Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-16T20:41:07.5782745Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-16T21:08:07.3675063Z .................................................................................................... 1700/9897
2020-04-16T21:08:11.8338527Z .................................................................................................... 1800/9897
2020-04-16T21:08:20.3925213Z .................................................................................................... 1900/9897
2020-04-16T21:08:28.7744160Z ......i............................................................................................. 2000/9897
2020-04-16T21:08:35.3070213Z ................................................................................................iiii 2100/9897
2020-04-16T21:08:50.7405306Z i................................................................................................... 2200/9897
2020-04-16T21:08:59.1372179Z .................................................................................................... 2400/9897
2020-04-16T21:09:01.7479037Z .................................................................................................... 2500/9897
2020-04-16T21:09:07.5358451Z .................................................................................................... 2600/9897
2020-04-16T21:09:28.0802585Z .................................................................................................... 2700/9897
---
2020-04-16T21:12:16.6820863Z .................................................................................................... 5100/9897
2020-04-16T21:12:25.1122482Z .................................................................................................... 5200/9897
2020-04-16T21:12:30.0825435Z .................i.................................................................................. 5300/9897
2020-04-16T21:12:41.1810005Z .......i............................................................................................ 5400/9897
2020-04-16T21:12:47.1612423Z .......ii.ii........i...i........................................................................... 5500/9897
2020-04-16T21:12:55.5937145Z .....................................................i.............................................. 5700/9897
2020-04-16T21:13:06.4664937Z .........................................................................ii......................... 5800/9897
2020-04-16T21:13:14.1007980Z ............i....................................................................................... 5900/9897
2020-04-16T21:13:19.9186567Z .................................................................................................... 6000/9897
2020-04-16T21:13:19.9186567Z .................................................................................................... 6000/9897
2020-04-16T21:13:31.4909860Z .................................................................................................... 6100/9897
2020-04-16T21:13:43.1773465Z ......ii...i..ii...........i........................................................................ 6200/9897
2020-04-16T21:13:59.2954886Z .................................................................................................... 6400/9897
2020-04-16T21:14:06.2350266Z .................................................................................................... 6500/9897
2020-04-16T21:14:06.2350266Z .................................................................................................... 6500/9897
2020-04-16T21:14:23.7492048Z ....................................i..ii........................................................... 6600/9897
2020-04-16T21:14:47.2474521Z .................................................................................................... 6800/9897
2020-04-16T21:14:49.3810198Z ....................................i............................................................... 6900/9897
2020-04-16T21:14:51.5564410Z .................................................................................................... 7000/9897
2020-04-16T21:14:53.7974697Z ............................................................................i....................... 7100/9897
---
2020-04-16T21:16:35.9520103Z .................................................................................................... 7800/9897
2020-04-16T21:16:40.3273391Z .................................................................................................... 7900/9897
2020-04-16T21:16:47.0978198Z .................................................................................................... 8000/9897
2020-04-16T21:16:53.6210321Z ..........................................i......................................................... 8100/9897
2020-04-16T21:17:03.5956959Z ..........................................................................................iiiiii.iii 8200/9897
2020-04-16T21:17:10.0809161Z ii.i................................................................................................ 8300/9897
2020-04-16T21:17:23.6791182Z .................................................................................................... 8500/9897
2020-04-16T21:17:33.6588760Z .................................................................................................... 8600/9897
2020-04-16T21:17:47.7026187Z .................................................................................................... 8700/9897
2020-04-16T21:17:54.5541955Z .................................................................................................... 8800/9897
---
2020-04-16T21:20:21.6628853Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-04-16T21:20:21.6821492Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-16T21:20:21.8852346Z 
2020-04-16T21:20:21.8852645Z running 185 tests
2020-04-16T21:20:24.7188464Z iiii......i............ii.i..iiii....i....i...........i............i..i..................i....i..... 100/185
2020-04-16T21:20:27.3798664Z .......i.i.i...iii..iiiiiiiiiiiiiiii.......................iii...............ii......
2020-04-16T21:20:27.3801365Z 
2020-04-16T21:20:27.3804814Z  finished in 5.697
2020-04-16T21:20:27.3837912Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-04-16T21:20:27.4054199Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-16T21:20:29.6123938Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-04-16T21:20:29.6304566Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-16T21:20:29.7873811Z 
2020-04-16T21:20:29.7874257Z running 9 tests
2020-04-16T21:20:29.7875672Z iiiiiiiii
2020-04-16T21:20:29.7877105Z 
2020-04-16T21:20:29.7879682Z  finished in 0.157
2020-04-16T21:20:29.7892129Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-04-16T21:20:29.8066170Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-16T21:20:51.1570647Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-04-16T21:20:51.1787790Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-16T21:20:51.3714542Z 
2020-04-16T21:20:51.3714886Z running 115 tests
2020-04-16T21:21:05.7524119Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-04-16T21:21:07.5276566Z ...iiii.....ii.
2020-04-16T21:21:07.5277800Z 
2020-04-16T21:21:07.5282882Z  finished in 16.349
2020-04-16T21:21:07.5291263Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-04-16T21:21:07.5294537Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-16T21:34:24.9548630Z 
2020-04-16T21:34:24.9554136Z    Doc-tests core
2020-04-16T21:34:30.1494607Z 
2020-04-16T21:34:30.1502593Z running 2496 tests
2020-04-16T21:34:39.9036508Z ......iiiii......................................................................................... 100/2496
2020-04-16T21:34:49.2681272Z .....................................................................................ii............. 200/2496
2020-04-16T21:35:10.9073421Z ....................i............................................................................... 400/2496
2020-04-16T21:35:10.9073421Z ....................i............................................................................... 400/2496
2020-04-16T21:35:21.2421493Z ..........................................................................i..i..................iiii 500/2496
2020-04-16T21:35:38.2054645Z .................................................................................................... 700/2496
2020-04-16T21:35:46.9535028Z .................................................................................................... 800/2496
2020-04-16T21:35:55.6876725Z .................................................................................................... 900/2496
2020-04-16T21:36:04.3666221Z .................................................................................................... 1000/2496
---
2020-04-16T21:39:45.8295565Z 
2020-04-16T21:39:45.8295887Z running 1020 tests
2020-04-16T21:40:04.2623604Z i................................................................................................... 100/1020
2020-04-16T21:40:14.7213798Z .................................................................................................... 200/1020
2020-04-16T21:40:22.5066399Z ...................iii......i......i...i......i..................................................... 300/1020
2020-04-16T21:40:27.4328979Z .................................................................................................... 400/1020
2020-04-16T21:40:34.1464032Z ....................................................i....i......................................ii.. 500/1020
2020-04-16T21:40:47.0807954Z .................................................................................................... 700/1020
2020-04-16T21:40:47.0807954Z .................................................................................................... 700/1020
2020-04-16T21:40:54.2668973Z ..............................................iiii.................................................. 800/1020
2020-04-16T21:41:08.3795493Z .................................................................................................... 900/1020
2020-04-16T21:41:14.6343598Z ....................................................................iiii............................ 1000/1020
2020-04-16T21:41:16.7631210Z test result: ok. 1000 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-04-16T21:41:16.7631642Z 
2020-04-16T21:41:16.7632063Z  finished in 170.597
2020-04-16T21:41:16.7633025Z Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
2020-04-16T21:44:40.4301721Z 
2020-04-16T21:44:40.4301955Z test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
2020-04-16T21:44:40.4302168Z 
2020-04-16T21:44:40.4367650Z  finished in 1.020
2020-04-16T21:44:40.4372858Z Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
2020-04-16T21:44:40.4390679Z Testing rustc_query_system stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-16T21:44:40.6299268Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-16T21:44:41.6786067Z      Running build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_query_system-5cdd81d9598f042b
2020-04-16T21:44:41.6813744Z 
2020-04-16T21:44:41.6814182Z running 0 tests
2020-04-16T21:44:41.6814292Z 
---
2020-04-16T21:59:59.9679915Z Set({"/checkout/src/librustc_parse"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9680730Z Set({"/checkout/src/librustc_passes"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9681548Z Set({"/checkout/src/librustc_plugin_impl"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9682734Z Set({"/checkout/src/librustc_privacy"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9683875Z Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9685913Z Set({"/checkout/src/librustc_save_analysis"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9687204Z Set({"/checkout/src/librustc_session"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9688104Z Set({"/checkout/src/librustc_span"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-16T21:59:59.9689146Z Set({"/checkout/src/librustc_symbol_mangling"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
---
2020-04-16T22:01:05.2776968Z   |
2020-04-16T22:01:05.2777116Z 5 |         //! foo
2020-04-16T22:01:05.2777269Z   |         ^^^^^^^
2020-04-16T22:01:05.2777396Z   |
2020-04-16T22:01:05.2777790Z   = note: inner attributes, like `#![no_std]`, annotate the item enclosing them, and are usually found at the beginning of source files. Outer attributes, like `#[test]`, annotate the item following them.
2020-04-16T22:01:05.2778952Z error: aborting due to previous error
2020-04-16T22:01:05.2779094Z 
2020-04-16T22:01:05.2779094Z 
2020-04-16T22:01:05.2779305Z Some expected error codes were not found: ["E0752"]
2020-04-16T22:01:05.2779809Z failures:
2020-04-16T22:01:05.2780766Z     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0752 (line 14343)
2020-04-16T22:01:05.2781251Z 
2020-04-16T22:01:05.2781494Z test result: FAILED. 864 passed; 1 failed; 18 ignored; 0 measured; 0 filtered out
---
2020-04-16T22:01:05.2783154Z 
2020-04-16T22:01:05.2783592Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-16T22:01:05.2784072Z Build completed unsuccessfully in 1:49:07
2020-04-16T22:01:05.2784271Z == clock drift check ==
2020-04-16T22:01:05.2784467Z   local time: Thu Apr 16 22:01:05 UTC 2020
2020-04-16T22:01:05.2797689Z   network time: Thu, 16 Apr 2020 22:01:05 GMT
2020-04-16T22:01:05.6406880Z 
2020-04-16T22:01:05.6406880Z 
2020-04-16T22:01:05.6508354Z ##[error]Bash exited with code '1'.
2020-04-16T22:01:05.6523479Z ##[section]Finishing: Run build
2020-04-16T22:01:05.6568261Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71214/merge to s
2020-04-16T22:01:05.6572851Z Task         : Get sources
2020-04-16T22:01:05.6573390Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-16T22:01:05.6573661Z Version      : 1.0.0
2020-04-16T22:01:05.6573838Z Author       : Microsoft
2020-04-16T22:01:05.6573838Z Author       : Microsoft
2020-04-16T22:01:05.6574126Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-16T22:01:05.6574464Z ==============================================================================
2020-04-16T22:01:06.0230660Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-16T22:01:06.0272158Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71214/merge to s
2020-04-16T22:01:06.0364199Z Cleaning up task key
2020-04-16T22:01:06.0365272Z Start cleaning up orphan processes.
2020-04-16T22:01:06.0555610Z Terminate orphan process: pid (3613) (python)
2020-04-16T22:01:06.0793388Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

GuillaumeGomez · 2020-04-19T11:13:55Z

CI passed.

bors · 2020-04-21T04:35:54Z

☔ The latest upstream changes (presumably #71367) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez · 2020-04-22T09:10:30Z

Updated!

Dylan-DPC-zz · 2020-04-22T09:53:26Z

@bors r+ rollup

bors · 2020-04-22T09:53:28Z

📌 Commit 038f5b7 has been approved by Dylan-DPC

@ghost

Rollup of 6 pull requests Successful merges: - rust-lang#70970 (Detect mistyped associated consts in `Instance::resolve`.) - rust-lang#71203 (Correct await span for async-await error reporting) - rust-lang#71214 (Add error code for inner doc error) - rust-lang#71337 (Moving all rustdoc-ui tests to check-pass) - rust-lang#71412 (Clarify unused_doc_comments note on macro invocations) - rust-lang#71414 (More diagnostic items for Clippy usage) Failed merges: r? @ghost

rust-highfive assigned Dylan-DPC-zz Apr 16, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2020

GuillaumeGomez changed the title ~~Add error code inner doc error~~ Add error code for inner doc error Apr 16, 2020

GuillaumeGomez force-pushed the add-error-code-inner-doc-error branch from c85e29a to 6bb4951 Compare April 16, 2020 20:07

GuillaumeGomez force-pushed the add-error-code-inner-doc-error branch 2 times, most recently from 735dfc2 to e7a9473 Compare April 18, 2020 22:30

GuillaumeGomez added 2 commits April 22, 2020 11:08

Add error code to inner doc comment attribute error

3390ff9

Update UI tests

038f5b7

GuillaumeGomez force-pushed the add-error-code-inner-doc-error branch from e7a9473 to 038f5b7 Compare April 22, 2020 09:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2020

Dylan-DPC-zz mentioned this pull request Apr 22, 2020

Rollup of 6 pull requests #71424

Merged

bors merged commit 372d37b into rust-lang:master Apr 22, 2020

GuillaumeGomez deleted the add-error-code-inner-doc-error branch April 22, 2020 19:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add error code for inner doc error #71214

Add error code for inner doc error #71214

GuillaumeGomez commented Apr 16, 2020

rust-highfive commented Apr 16, 2020

rust-highfive commented Apr 16, 2020

GuillaumeGomez commented Apr 19, 2020

bors commented Apr 21, 2020

GuillaumeGomez commented Apr 22, 2020

Dylan-DPC-zz commented Apr 22, 2020

bors commented Apr 22, 2020

Add error code for inner doc error #71214

Add error code for inner doc error #71214

Conversation

GuillaumeGomez commented Apr 16, 2020

rust-highfive commented Apr 16, 2020

rust-highfive commented Apr 16, 2020

GuillaumeGomez commented Apr 19, 2020

bors commented Apr 21, 2020

GuillaumeGomez commented Apr 22, 2020

Dylan-DPC-zz commented Apr 22, 2020

bors commented Apr 22, 2020