-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Dogfood more or_patterns in the compiler #71231
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@bors r+ |
📌 Commit e6482c87f380124207f16a60103f74646c52c541 has been approved by |
failed in rollup @bors r- |
☔ The latest upstream changes (presumably #71049) made this pull request unmergeable. Please resolve the merge conflicts. |
@Dylan-DPC was that failed as in broke some functionality? Or simply failed to merge -- since this touches a lot of code, conflicts are somewhat likely. (And now @bors reports a merge conflict anyway, so I'll fix that.) |
📌 Commit e6482c87f380124207f16a60103f74646c52c541 has been approved by |
No sorry, by failed I meant due to conflicts not due to the CI |
@bors p=1 |
(Well, actually, that approval is useless as this has conflicts, but that's fine. @cuviper feel free to approve as needed). |
nevermind :D |
e6482c8
to
1d25129
Compare
@bors r=Mark-Simulacrum |
📌 Commit 1d251291903788e0c005320e45370a81725a743a has been approved by |
⌛ Testing commit 1d251291903788e0c005320e45370a81725a743a with merge b07f26ee00acf5842ccdc54997fab4450a610bd9... |
💔 Test failed - checks-azure |
💔 Test failed - checks-azure |
Timeout installing msys... @bors retry |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #69793) made this pull request unmergeable. Please resolve the merge conflicts. |
1d25129
to
7b005c5
Compare
@bors r=Mark-Simulacrum |
📌 Commit 7b005c5 has been approved by |
☀️ Test successful - checks-azure |
Another step toward the stabilization of
or_patterns
...cc #54883 @Centril
r? @Mark-Simulacrum