Minor refactoring around IndexVec usage in generator transformation #71551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize IndexVec::push to avoid redundant object creation.
rust-highfive
added
the
S-waiting-on-review
|
Changes look good to me. Let's run benchmarks just in case. @bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 7749591 with merge 15d7fec3d3e5a10776e0f42253cd52b579e4cfa5... |
|
☀️ Try build successful - checks-azure |
|
Queued 15d7fec3d3e5a10776e0f42253cd52b579e4cfa5 with parent a58b1ed, future comparison URL. |
|
@bors r+ |
|
📌 Commit 7749591 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71421 (Add a function to turn Box<T> into Box<[T]>) - rust-lang#71537 (Remove support for self-opening) - rust-lang#71551 (Minor refactoring around IndexVec usage in generator transformation) - rust-lang#71569 ([miri] Throw UB if target size and data size don't match) - rust-lang#71576 (check that `AsRef` and `AsMut` are inlined) Failed merges: - rust-lang#71558 (Cleanup and document `-Z tls-model` ) r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hash map with IndexVec for liveness data.
Utilize IndexVec::push return value to avoid redundant object creation.
r? @eddyb