Ref bindings explicit copy in generics #7167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Glad to see this. Moving out of * is scary. |
|
@brson thanks for the quick review. this seems like a patch that has very few "substantive" changes (two lines) but is very prone to bitrot ... :) |
|
oh, never mind, I guess he does understand p=2000. :) |
…opy bound. Consider: T:Copy could be bound to ~T, which is not implicitly copyable.
…ed-on-type, since it creates moves that were not apparent. It also turns out to be not widely used.
bors
added a commit
that referenced
this pull request
Jun 16, 2013
…-generics, r=brson Two changes: 1. Make type parameters move by default, even if they have a Copy bound. After all, they could be bound to `~T` or `~[]`. Also, this is a necessary step towards removing `copy` keyword and replacing with clone. 2. Make it illegal to move from `*T`. This is dangerous in a "moves-by-default" scenario, because it's very easy to move when working with a `*T` pointer. Also, it requires zeroing memory, which we hope to do away with someday.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 6, 2021
Fix unused_unit macro false positive changelog: Fix [`unused_unit`] false positive with macros Fixes rust-lang#7055
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
~Tor~[]. Also, this is a necessary step towards removingcopykeyword and replacing with clone.*T. This is dangerous in a "moves-by-default" scenario, because it's very easy to move when working with a*Tpointer. Also, it requires zeroing memory, which we hope to do away with someday.