Const prop aggregates even if partially or fully modified

[oli-obk]

r? @wesleywiser

cc @rust-lang/wg-mir-opt I'm moderately scared of this change, but I'm confident in having reviewed all the cases.

[wesleywiser]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion

[bors]

⌛ Trying commit a1ebb94 with merge 274c308239850d9f5a2a2a9067bcc5c41ab35a6d...

[wesleywiser]

Agreed: it does seem a bit scary but the code appears correct. Let's see what perf says.

[bors]

☀️ Try build successful - checks-actions, checks-azure
Build commit: 274c308239850d9f5a2a2a9067bcc5c41ab35a6d (274c308239850d9f5a2a2a9067bcc5c41ab35a6d)

[rust-timer]

Queued 274c308239850d9f5a2a2a9067bcc5c41ab35a6d with parent 97f3eee, future comparison URL.

[wesleywiser]

Let's try that again:

@rust-timer queue 274c308239850d9f5a2a2a9067bcc5c41ab35a6d

[rust-timer]

Awaiting bors try build completion

[wesleywiser]

Oh, looks like it's still in the queue...

[oli-obk]

@rust-timer build 274c308239850d9f5a2a2a9067bcc5c41ab35a6d

[rust-timer]

Queued 274c308239850d9f5a2a2a9067bcc5c41ab35a6d with parent 97f3eee, future comparison URL.

[rust-timer]

Finished benchmarking try commit 274c308239850d9f5a2a2a9067bcc5c41ab35a6d, comparison URL.

[oli-obk]

@rust-timer build 274c308

[rust-timer]

Queued 274c308239850d9f5a2a2a9067bcc5c41ab35a6d with parent 97f3eee, future comparison URL.

[mati865]

Perf shows minimal improvement.

[wesleywiser]

I think we mostly wanted to make sure this didn't cause any regressions.

@bors r+

[bors]

📌 Commit a1ebb94 has been approved by wesleywiser

[bors]

⌛ Testing commit a1ebb94 with merge 3fe4dd2...

[bors]

☀️ Test successful - checks-actions, checks-azure
Approved by: wesleywiser
Pushing 3fe4dd2 to master...