Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Don't add attribute to allow unused-qualifications to derive impl's #71969

Closed
wants to merge 1 commit into from
Closed

Don't add attribute to allow unused-qualifications to derive impl's #71969

wants to merge 1 commit into from

Conversation

samrat
Copy link
Contributor

@samrat samrat commented May 7, 2020

Currently #![forbid(unused_qualifications)] is incompatible with all derive's because we add #[allow(unused_qualifications)] in all generated impl's.

Closes #71898

@samrat
Don't add attribute to allow unused-qualifications to derive impl's
54a6757 
Currently `#![forbid(unused_qualifications)]` is incompatible with all
derive's because we add `#[allow(unused_qualifications)]` in all
generated impl's.
@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2020
@cramertj
Copy link
Member

cramertj commented May 8, 2020

r? @jonas-schievink

@bors
Copy link
Collaborator

bors commented May 9, 2020

☔ The latest upstream changes (presumably #72041) made this pull request unmergeable. Please resolve the merge conflicts.

@Muirrum
Copy link
Member

Muirrum commented Jun 13, 2020

@rustbot modify labels to +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2020
@jonas-schievink
Copy link
Contributor

r? @varkor

@samrat samrat marked this pull request as ready for review June 13, 2020 15:03
@varkor
Copy link
Member

varkor commented Jun 18, 2020

The #[allow(unused_qualifications)] was originally added to fix #19102. Does this issue no longer occur even without it?

@Elinvynia
Copy link
Contributor

Ping from triage: @samrat
Hello, it looks like this PR also needs a rebase, could you have a look when you have the time?

@Elinvynia Elinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2020
@Muirrum
Copy link
Member

Muirrum commented Jul 24, 2020

Another ping from triage @samrat

@Dylan-DPC-zz
Copy link

@samrat closing this pr due to inactivity. If you have time again, you can open a new pr with these changes. Thanks for taking the time to contribute :)

@Dylan-DPC-zz Dylan-DPC-zz added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@varkor varkor

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[forbid(unused_qualifications)] is incompatible with all builtin derives
10 participants
@samrat @rust-highfive @cramertj @bors @Muirrum @jonas-schievink @varkor @Elinvynia @Dylan-DPC-zz @rustbot