Refactor and adjust non_ascii_idents lints. #72069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Manishearth |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
crlf0710
force-pushed
the
confusable_idents
branch
from
634b66b to
649a579
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
crlf0710
force-pushed
the
confusable_idents
branch
from
649a579 to
98c4109
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
It seems |
crlf0710
force-pushed
the
confusable_idents
branch
from
98c4109 to
ae4c778
Compare
crlf0710
changed the title
crlf0710
force-pushed
the
confusable_idents
branch
from
ae4c778 to
1dd5779
Compare
Manishearth
approved these changes
May 11, 2020
|
Is this ready to be r+-ed? Also cc @petrochenkov and @Mark-Simulacrum in case they want to have another look. The TL;DR is that since we can skip pure-ascii codebases now, this should no longer have compilation performance regression any more(other than a FxHashMap -> BTreeMap switch), and now i've turned on |
|
@bors try @rust-timer queue I want to just check that we're correct that this is not a performance regression. I've not reviewed the code in any detail. |
|
Awaiting bors try build completion |
|
⌛ Trying commit 1dd5779cd561d16782839c1b2ae98b08a6f953de with merge 54ca6faced00c0770b52ac83b46739e6b848975b... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
crlf0710
added
S-waiting-on-review
|
Mmm, the try bot seems unable to checkout the source code. What does this mean... cc @Mark-Simulacrum |
|
Hm seems spurious, let's @bors retry |
|
⌛ Trying commit 1dd5779cd561d16782839c1b2ae98b08a6f953de with merge aac49fd2f8e21d595802bc204841ec02b0505f7e... |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued aac49fd2f8e21d595802bc204841ec02b0505f7e with parent 750db09, future comparison URL. |
|
Finished benchmarking try commit aac49fd2f8e21d595802bc204841ec02b0505f7e, comparison URL. |
|
Seems good enough to me. However some more modifications to rust-lang/rfcs#2923 modification PR is being discussed, i think let's wait a bit. |
|
Fwiw I don't think we need to immediately update the RFC. The RFC typically doesn't even need to be updated in cases like this. |
|
Oh, I see what you mean |
crlf0710
added
S-blocked
crlf0710
force-pushed
the
confusable_idents
branch
from
1dd5779 to
ef24faf
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 26, 2020
…=Manishearth Implement mixed script confusable lint. This implements the mixed script confusable lint defined in RFC 2457. This is blocked on rust-lang#72069 and unicode-rs/unicode-security#13, and will need a Cargo.toml version bump after those are resolved. The lint message warning is sub-optimal for now. We'll need a mechanism to properly output `AugmentScriptSet` to screen, this is to be added in `unicode-security` crate. r? @Manishearth
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 26, 2020
…=Manishearth Implement mixed script confusable lint. This implements the mixed script confusable lint defined in RFC 2457. This is blocked on rust-lang#72069 and unicode-rs/unicode-security#13, and will need a Cargo.toml version bump after those are resolved. The lint message warning is sub-optimal for now. We'll need a mechanism to properly output `AugmentScriptSet` to screen, this is to be added in `unicode-security` crate. r? @Manishearth
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 26, 2020
…=Manishearth Implement mixed script confusable lint. This implements the mixed script confusable lint defined in RFC 2457. This is blocked on rust-lang#72069 and unicode-rs/unicode-security#13, and will need a Cargo.toml version bump after those are resolved. The lint message warning is sub-optimal for now. We'll need a mechanism to properly output `AugmentScriptSet` to screen, this is to be added in `unicode-security` crate. r? @Manishearth
crlf0710
added
S-waiting-on-bors
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adjustment is according to rust-lang/rfcs#2923 . This also turned on confusable_idents lint, since the performance impact is resolved by this adjustment.