Change WorkProduct::saved_files to an Option.
#72126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
May 12, 2020
|
I am not a member of rust-lang |
Because there is at most one file.
nnethercote
force-pushed
the
change-WorkProduct-saved_files
branch
from
f13189e to
98d6254
Compare
|
@bors: r+ |
|
📌 Commit 98d6254 has been approved by |
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 12, 2020
…d_files, r=alexcrichton Change `WorkProduct::saved_files` to an `Option`. Because there is at most one file. r? @bjorn3
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 13, 2020
…d_files, r=alexcrichton Change `WorkProduct::saved_files` to an `Option`. Because there is at most one file. r? @bjorn3
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#71910 (Fix unused_parens false positive when using binary operations) - rust-lang#72087 (Fix hang in lexical_region_resolve) - rust-lang#72126 (Change `WorkProduct::saved_files` to an `Option`.) - rust-lang#72127 (add long error explanation for E0228) - rust-lang#72141 (Warn against thread::sleep in async fn) - rust-lang#72170 (use `require_lang_item` over `unwrap`.) - rust-lang#72191 (Clean up E0589 explanation) - rust-lang#72194 (Don't ICE on missing `Unsize` impl) Failed merges: r? @ghost
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there is at most one file.
r? @bjorn3