Skip to content

Rollup of 9 pull requests #72182

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 18 commits into from

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

ldm0 and others added 18 commits April 25, 2020 08:56
`prefix` should not be mutable.

Change the process from for loop to find, which makes the `prefix` able to be immutable.
…matsakis

Fix hang in lexical_region_resolve

Regionck was stuck in a loop where a region value was changing between two equal regions.

Closes rust-lang#72051
…E0228, r=petrochenkov

add long error explanation for E0228

Add long explanation for the E0228 error code
Part of rust-lang#61137

Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
…hewjasper

Add doc comment for `rustc_middle::mir::mono::Linkage`
Warn against thread::sleep in async fn

I've seen `thread::sleep` wrecking havoc in async servers. There's already an [issue for clippy](rust-lang/rust-clippy#4377), but the std docs could warn against it too.
…atsakis

Remove UnnormalizedProjection

This was only used for the old chalk integration with chalk-engine

r? @nikomatsakis
…wjasper

docs: remove comment referencing non-existent method
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=9

@bors
Copy link
Collaborator

bors commented May 13, 2020

📌 Commit c44a762 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 13, 2020
@bors
Copy link
Collaborator

bors commented May 14, 2020

⌛ Testing commit c44a762 with merge 8ab0258cb3022089fc3a23a12ff51a0b5b9dcd9c...

@bors
Copy link
Collaborator

bors commented May 14, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2020
@RalfJung
Copy link
Member

@rust-lang/infra I am unable to see the failure in this run -- the only failing job is "mark the job as failure". Usually then there is another job that also failed that shows the actual error; that does not seem to be the case this time.

@kennytm
Copy link
Member

kennytm commented May 14, 2020

@bors retry #71988.

The two canceled jobs in this run are:

  • dist-x86_64-apple, spent 11m 52s on "upload artifacts to S3" (the builds only take several seconds for this step)
  • x86_64-apple, canceled in the middle of "run the build"

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2020
@RalfJung
Copy link
Member

@bors r-
Closing in favor of #72187

@RalfJung RalfJung closed this May 14, 2020
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2020
@RalfJung RalfJung added the rollup A PR which is a rollup label May 14, 2020
@kennytm
Copy link
Member

kennytm commented May 18, 2020

@bors p=0 r- retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 18, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.