-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Ensure stack when building MIR for matches #72941
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 7f1585fb9360ca54ea0a3fe156a324516d248fa8 with merge cdab6c297e7845cb27538ad94520e316cb680fb7... |
Running a timing as I just gone ahead and stuck a |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
In particular matching on complex types such as strings will cause deep recursion to happen. Fixes rust-lang#72933
7f1585f
to
6b1ee67
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 6b1ee67 with merge ec1ed34e80a25ce5ffc9a484481731a807be7f4d... |
☀️ Try build successful - checks-azure |
Queued ec1ed34e80a25ce5ffc9a484481731a807be7f4d with parent ff4aff6, future comparison URL. |
Finished benchmarking try commit ec1ed34e80a25ce5ffc9a484481731a807be7f4d, comparison URL. |
Looks good to me. Perf is also clean. The test is a bit annoyingly big, but I can't think of anything to change here. Generating it from a proc macro is overkill. @bors r+ |
📌 Commit 6b1ee67 has been approved by |
…i-obk Ensure stack when building MIR for matches In particular matching on complex types such as strings will cause deep recursion to happen. Fixes rust-lang#72933 r? @matthewjasper @oli-obk
Rollup of 11 pull requests Successful merges: - rust-lang#72380 (Fix `is_const_context`, update `check_for_cast`) - rust-lang#72941 (Ensure stack when building MIR for matches) - rust-lang#72976 (Clean up E0642 explanation) - rust-lang#73080 (doc/rustdoc: Fix incorrect external_doc feature flag) - rust-lang#73155 (save_analysis: better handle paths and functions signature) - rust-lang#73164 (Add new E0762 error code) - rust-lang#73172 (Fix more clippy warnings) - rust-lang#73181 (Automatically prioritize unsoundness issues) - rust-lang#73183 (Support proc macros in intra doc link resolution) - rust-lang#73208 (Fix doctest template) - rust-lang#73219 (x.py: with --json-output, forward cargo's JSON) Failed merges: r? @ghost
Discussed at T-compiler meeting; beta backport approved. |
…ulacrum [beta] backports This PR backports the following: * Make novel structural match violations not a `bug` rust-lang#73446 * linker: Never pass `-no-pie` to non-gnu linkers rust-lang#73384 * Disable the `SimplifyArmIdentity` pass rust-lang#73262 * Allow inference regions when relating consts rust-lang#73225 * Fix link error with #[thread_local] introduced by rust-lang#71192 rust-lang#73065 * Ensure stack when building MIR for matches rust-lang#72941 * Don't create impl candidates when obligation contains errors rust-lang#73005 r? @ghost
In particular matching on complex types such as strings will cause
deep recursion to happen.
Fixes #72933
r? @matthewjasper @oli-obk