Skip to content

Remove noisy suggestion of hash_map #73023

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Remove noisy suggestion of hash_map #73023

merged 1 commit into from
Jun 11, 2020

Conversation

ayushmishra2005
Copy link
Contributor

@ayushmishra2005 ayushmishra2005 commented Jun 5, 2020 •
edited
Loading

Remove noisy suggestion of hash_map #72642

fixes #72642

@rust-highfive
Copy link
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2020
@ayushmishra2005
Copy link
Contributor Author

ayushmishra2005 commented Jun 5, 2020 •
edited
Loading

r? @davidtwco Sorry to bother you again. Can you please review and approve this PR?

@ayushmishra2005
Copy link
Contributor Author

@Dylan-DPC @lzutao @lcnr I have raised new PR and closed #72947. Please take a look.

lcnr
lcnr approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Please add fixes #72642 to the description of this PR.
This automatically closes that issue once this PR is merged.

edit: what was the reason for closing the original PR?

@davidtwco
Copy link
Member

davidtwco commented Jun 5, 2020 •
edited
Loading

Will r+ once CI passes!

@ayushmishra2005
Copy link
Contributor Author

Thanks

Please add fixes #72642 to the description of this PR.
This automatically closes that issue once this PR is merged.

edit: what was the reason for closing the original PR?

@lcnr I did something wrong while squashing the commit. That's why I raised fresh PR.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 5, 2020

📌 Commit 9d1a883 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2020
@chrissimpkins chrissimpkins mentioned this pull request Jun 5, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#73023 - ayushmishra2005:remove_noisy_sugges…
aa99f19 
…tion, r=davidtwco

Remove noisy suggestion of hash_map

Remove noisy suggestion of hash_map rust-lang#72642

fixes rust-lang#72642
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 5, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#73023 - ayushmishra2005:remove_noisy_sugges…
5ef591e 
…tion, r=davidtwco

Remove noisy suggestion of hash_map

Remove noisy suggestion of hash_map rust-lang#72642

fixes rust-lang#72642
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 5, 2020
Closed
@ayushmishra2005 ayushmishra2005 force-pushed the remove_noisy_suggestion branch 2 times, most recently from 7edbb63 to b786296 Compare June 7, 2020 10:50
@ayushmishra2005
Copy link
Contributor Author

@Dylan-DPC Please let me know if anything is pending from my side. I rebased my PR with the master branch. CI pipeline is working fine.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 7, 2020

📌 Commit b7862969bf3671b767693d8f31d58424c6592d91 has been approved by davidtwco

Remove noisy suggestion of hash_map rust-lang#72642
b055552 
Fixed failing test-cases

Remove noisy suggestion of hash_map rust-lang#72642

Fixed failing test-cases
@ayushmishra2005 ayushmishra2005 force-pushed the remove_noisy_suggestion branch from b786296 to b055552 Compare June 9, 2020 03:28
@ayushmishra2005
Copy link
Contributor Author

@Dylan-DPC Please let me know if there is anything stopping this PR to be merged in master. This PR has been approved by the reviewer @davidtwco . I have been rebasing with master on daily basis and CI pipeline is also green.

Please let me know if there is anything pending from my side. I would address it asap.
Thanks

@davidtwco
Copy link
Member

@ayushmishra2005 Unless there are conflicts or CI failures while merging, you don’t need to rebase - every time you do, I need to reapprove. It’s in the merge queue.

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 9, 2020

📌 Commit b055552 has been approved by davidtwco

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2020
@bors
Auto merge of rust-lang#73206 - Dylan-DPC:rollup-rha9g8q, r=Dylan-DPC
ec42485 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#72706 (Add windows group to triagebot)
 - rust-lang#72789 (resolve: Do not suggest imports from the same module in which we are resolving)
 - rust-lang#72890 (improper ctypes: normalize return types and transparent structs)
 - rust-lang#72897 (normalize adt fields during structural match checking)
 - rust-lang#73005 (Don't create impl candidates when obligation contains errors)
 - rust-lang#73023 (Remove noisy suggestion of hash_map )
 - rust-lang#73070 (Add regression test for const generic ICE in rust-lang#72819)
 - rust-lang#73157 (Don't lose empty `where` clause when pretty-printing)
 - rust-lang#73184 (Reoder order in which MinGW libs are linked to fix recent breakage)

Failed merges:

r? @ghost
@bors bors merged commit e1cd8c4 into rust-lang:master Jun 11, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

@lcnr lcnr lcnr approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

Do not suggest importing hash_map::HashMap or btree_map::BTreeMap
7 participants
@ayushmishra2005 @rust-highfive @davidtwco @bors @lcnr @cuviper @ecstatic-morse