[DO NOT MERGE] perf only: disable default MIR validation #73087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 8a6cb26 with merge 6a562464d19b3a8b4c4fa14568181baa66e4197c... |
|
☀️ Try build successful - checks-azure |
|
Queued 6a562464d19b3a8b4c4fa14568181baa66e4197c with parent 450abe8, future comparison URL. |
|
Finished benchmarking try commit (6a562464d19b3a8b4c4fa14568181baa66e4197c): comparison url. |
|
Looks like indeed this is insignificant. Good to know. Cc @nnethercote -- just FYI. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if the MIR validation we have so far has any measurable perf impact.
Cc @jonas-schievink