Skip to content

Clean up E0646 #73092

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

Clean up E0646 #73092

merged 1 commit into from
Jun 8, 2020

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2020
pickfire
pickfire approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 7, 2020

📌 Commit af68249 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 7, 2020
@Dylan-DPC
Rollup merge of rust-lang#73092 - GuillaumeGomez:cleanup-e0646, r=Dyl…
eb31879 
…an-DPC

Clean up E0646

r? @Dylan-DPC
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 7, 2020
Closed
@RalfJung RalfJung mentioned this pull request Jun 8, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2020
@bors
Auto merge of rust-lang#73115 - RalfJung:rollup-jecowhz, r=RalfJung
bc10b68 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#72026 (Update annotate-snippets-rs to 0.8.0)
 - rust-lang#72583 (impl AsRef<[T]> for vec::IntoIter<T>)
 - rust-lang#72615 (Fix documentation example for gcov profiling)
 - rust-lang#72761 (Added the documentation for the 'use' keyword)
 - rust-lang#72799 (Add `-Z span-debug` to allow for easier debugging of proc macros)
 - rust-lang#72811 (Liballoc impl)
 - rust-lang#72963 (Cstring `from_raw` and `into_raw` safety precisions)
 - rust-lang#73001 (Free `default()` forwarding to `Default::default()`)
 - rust-lang#73075 (Add comments to `Resolve::get_module`)
 - rust-lang#73092 (Clean up E0646)

Failed merges:

r? @ghost
@bors bors merged commit 7983e56 into rust-lang:master Jun 8, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0646 branch June 9, 2020 09:43
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @Dylan-DPC-zz @bors @pickfire @cuviper @rust-highfive