Skip to content

Move contributing.md to rustc-dev-guide and point at getting started #73454

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2020
Merged

Move contributing.md to rustc-dev-guide and point at getting started #73454

merged 1 commit into from
Jul 3, 2020

Conversation

mark-i-m
Copy link
Member

See description on rust-lang/rustc-dev-guide#753

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2020
@mark-i-m
Copy link
Member Author

@rustbot modify labels: +S-blocked

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jun 17, 2020
@mark-i-m
Copy link
Member Author

The getting started guide is up: https://rustc-dev-guide.rust-lang.org/getting-started.html

@rustbot modify labels: -S-blocked

@nikomatsakis Would it make sense to do an FCP/MCP or something here?

@rustbot rustbot removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jun 23, 2020
@nikomatsakis
Copy link
Contributor

I don't really think it's necessary, but I also don't think it could hurt. I would happily second it.

@mark-i-m mark-i-m mentioned this pull request Jun 23, 2020
Closed
3 tasks
@nikomatsakis
Copy link
Contributor

I'm going to go ahead and r+ -- if the MCP got 8 days into FCP, I think it's fine, and this is reversible.

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 1, 2020

📌 Commit 3f6928f has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2020
@nikomatsakis
Copy link
Contributor

@bors r-

Well, wait, I guess that rust-lang/rustc-dev-guide#753 should merge first...?

r=me in any case.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 1, 2020
@mark-i-m
Copy link
Member Author

mark-i-m commented Jul 2, 2020

@nikomatsakis I just merged #753

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 2, 2020

📌 Commit 3f6928f has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2020
@Manishearth
Rollup merge of rust-lang#73454 - mark-i-m:contributing, r=nikomatsakis
50481d0 
Move contributing.md to rustc-dev-guide and point at getting started

See description on rust-lang/rustc-dev-guide#753
@Manishearth Manishearth mentioned this pull request Jul 2, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 2, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2020
@bors
Auto merge of rust-lang#73977 - Manishearth:rollup-2x4s7c6, r=Manishe…
5f4abc1 
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#73454 (Move contributing.md to rustc-dev-guide and point at getting started)
 - rust-lang#73724 (Use WASM's saturating casts if they are available)
 - rust-lang#73726 (resolve: disallow labelled breaks/continues through closures/async blocks)
 - rust-lang#73753 (Use 'tcx for references to AccessLevels wherever possible.)
 - rust-lang#73781 (Update psm version)
 - rust-lang#73952 (Add option for local docker testing.)
 - rust-lang#73957 (disable BTree min_max test in Miri for now)
 - rust-lang#73975 (Document rustc_ast::ast::Pat)

Failed merges:

r? @ghost
@bors bors merged commit dc6a19c into rust-lang:master Jul 3, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@mark-i-m @rust-highfive @nikomatsakis @bors @cuviper @rustbot