Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

deprecate wrapping_offset_from #73580

Merged
merged 1 commit into from
Jun 22, 2020
Merged

deprecate wrapping_offset_from #73580

merged 1 commit into from
Jun 22, 2020

Conversation

RalfJung
Copy link
Member

As per #41079 (comment) which seems like a consensus.

r? @Amanieu

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jun 21, 2020

cc @scottmcm who originally mused whether we want a wrapping_* variant of this

@RalfJung RalfJung force-pushed the deprecate-wrapping-offset-from branch from cebf727 to 467415d Compare June 21, 2020 11:50
@Amanieu
Copy link
Member

Amanieu commented Jun 21, 2020

r=me assuming no objections.

@RalfJung
Copy link
Member Author

@rust-lang/libs any objections to this deprecation of the unstable method wrapping_offset_from? @Amanieu said about it some time ago

Regarding wrapping_offset_from, I personally feel that there isn't much point to this function. The only thing that I can think of could be to calculate the position of a &T in a slice without using any unsafe code, but then again this is sufficiently niche that I don't feel it is worth adding a function just for that.

@dtolnay dtolnay added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 21, 2020
@dtolnay
Copy link
Member

dtolnay commented Jun 21, 2020

I see a 👍 from sfackler so with three of us I think this is good to go.
@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Jun 21, 2020

📌 Commit 467415d has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2020
@RalfJung
Copy link
Member Author

@bors rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 21, 2020
@Manishearth
Rollup merge of rust-lang#73580 - RalfJung:deprecate-wrapping-offset-…
91d0414 
…from, r=Amanieu

deprecate wrapping_offset_from

As per rust-lang#41079 (comment) which seems like a consensus.

r? @Amanieu
@Manishearth Manishearth mentioned this pull request Jun 21, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 21, 2020
@Manishearth
Rollup merge of rust-lang#73580 - RalfJung:deprecate-wrapping-offset-…
8db431e 
…from, r=Amanieu

deprecate wrapping_offset_from

As per rust-lang#41079 (comment) which seems like a consensus.

r? @Amanieu
@Manishearth Manishearth mentioned this pull request Jun 21, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2020
@Manishearth
Rollup merge of rust-lang#73580 - RalfJung:deprecate-wrapping-offset-…
84560a4 
…from, r=Amanieu

deprecate wrapping_offset_from

As per rust-lang#41079 (comment) which seems like a consensus.

r? @Amanieu
@Manishearth Manishearth mentioned this pull request Jun 22, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 22, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2020
@bors
Auto merge of rust-lang#73617 - Dylan-DPC:rollup-zugh80o, r=Dylan-DPC
62878c2 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#71660 (impl PartialEq<Vec<B>> for &[A], &mut [A])
 - rust-lang#72623 (Prefer accessible paths in 'use' suggestions)
 - rust-lang#73502 (Add E0765)
 - rust-lang#73580 (deprecate wrapping_offset_from)
 - rust-lang#73582 (Miri: replace many bug! by span_bug!)
 - rust-lang#73585 (Do not send a notification for P-high stable regressions)

Failed merges:

 - rust-lang#73581 (Create 0766 error code)

r? @ghost
@bors bors merged commit 35ecb26 into rust-lang:master Jun 22, 2020
@scottmcm
Copy link
Member

Thanks for the ping here, @oli-obk. My recollection is that that musing was from way back when the only method was the safe one (https://doc.rust-lang.org/1.22.0/std/primitive.pointer.html#method.offset_to), and I thought that there should probably be an unsafe one. I have no attachment to the safe one, and am fine with its removal.

yvt added a commit to r3-os/r3 that referenced this pull request Jun 25, 2020
@yvt
refactor(task): stop using the deprecated method wrapping_offset_from
eb752db 
`wrapping_offset_from` was deprecated by
<rust-lang/rust#73580>.
@RalfJung RalfJung deleted the deprecate-wrapping-offset-from branch June 28, 2020 07:19
@fanninpm fanninpm mentioned this pull request Dec 18, 2020
Closed
fw-immunant added a commit to immunant/c2rust that referenced this pull request Mar 31, 2022
@fw-immunant
replace removed wrapping_offset_from method with offset_from
2c67c1a 
see rust-lang/rust#73580
fw-immunant added a commit to immunant/c2rust that referenced this pull request Mar 31, 2022
@fw-immunant
replace removed wrapping_offset_from method with offset_from
080452a 
see rust-lang/rust#73580
fw-immunant added a commit to immunant/c2rust that referenced this pull request Apr 13, 2022
@fw-immunant
replace removed wrapping_offset_from method with offset_from
3fd394f 
see rust-lang/rust#73580
@RalfJung RalfJung mentioned this pull request Jul 4, 2023
Closed
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
8 participants
@RalfJung @oli-obk @Amanieu @dtolnay @bors @scottmcm @cuviper @rust-highfive