-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Allow for parentheses after macro intra-doc-links #73791
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Thanks! @bors: r+ |
📌 Commit 1ab8260494e31a214ad16a1278855d031698e399 has been approved by |
Shouldn't a test be added for this? |
Outch, good catch @ollie27 ! Please add a test @Manishearth. @bors: r- |
@ollie27 we mostly don't have tests for this kind of thing, i was considering adding them separately, but i can do that |
1ab8260
to
08d3a74
Compare
I was wrong, we do test this, it was just part of another test. |
@bors r=GuillaumeGomez,jyn514 rollup |
📌 Commit fe351e9 has been approved by |
…llaumeGomez,jyn514 Allow for parentheses after macro intra-doc-links None
…llaumeGomez,jyn514 Allow for parentheses after macro intra-doc-links None
…arth Rollup of 14 pull requests Successful merges: - rust-lang#73292 (Fixing broken link for the Eq trait) - rust-lang#73791 (Allow for parentheses after macro intra-doc-links) - rust-lang#74070 ( Use for<'tcx> fn pointers in Providers, instead of having Providers<'tcx>.) - rust-lang#74077 (Use relative path for local links to primitives) - rust-lang#74079 (Eliminate confusing "globals" terminology.) - rust-lang#74107 (Hide `&mut self` methods from Deref in sidebar if there are no `DerefMut` impl for the type.) - rust-lang#74136 (Fix broken link in rustdocdoc) - rust-lang#74137 (Update cargo) - rust-lang#74142 (Liballoc use vec instead of vector) - rust-lang#74143 (Try remove unneeded ToString import in liballoc slice) - rust-lang#74146 (update miri) - rust-lang#74150 (Avoid "blacklist") - rust-lang#74184 (Add docs for intra-doc-links) - rust-lang#74188 (Tweak `::` -> `:` typo heuristic and reduce verbosity) Failed merges: - rust-lang#74122 (Start-up clean-up) - rust-lang#74127 (Avoid "whitelist") r? @ghost
@bors p=5 trying something |
@bors p=0 |
No description provided.