Skip to content

Shrink grow_amortized() some more #73912

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Shrink grow_amortized() some more #73912

wants to merge 3 commits into from

Conversation

nnethercote
Copy link
Contributor

More reductions in the amount of LLVM IR generated, to improve build times.

r? @Amanieu

@nnethercote
Introduce array_layout.
6057361 
As a non-generic alternative to `Layout::array`.
@nnethercote
Avoid instantiating try_reserve{,_exact}.
e0ba4b7 
This reduces the amount of LLVM IR generated, slightly improving compile
times.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2020
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Jul 1, 2020

⌛ Trying commit d32fa4af1fac4c537fe45638db101b17ac92e1a7 with merge 00bce05b882a072eb6a889c4acf84ddc68d1ebe3...

@nnethercote
Copy link
Contributor Author

@bors rollup=never

Because of the perf effects.

@Manishearth
Copy link
Member

@bors p=1

lcnr
lcnr reviewed Jul 1, 2020
View reviewed changes
@bors
Copy link
Collaborator

bors commented Jul 1, 2020

💥 Test timed out

@nnethercote nnethercote force-pushed the shrink-grow_amortized-some-more branch from d32fa4a to cf808ff Compare July 1, 2020 22:34
@nnethercote
Copy link
Contributor Author

@bors try

@bors
Copy link
Collaborator

bors commented Jul 1, 2020

⌛ Trying commit cf808ff with merge fe2636a79c85ff9bf1a8b79bd8358dea6c24d1b6...

@bors
Copy link
Collaborator

bors commented Jul 2, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: fe2636a79c85ff9bf1a8b79bd8358dea6c24d1b6 (fe2636a79c85ff9bf1a8b79bd8358dea6c24d1b6)

@rust-timer
Copy link
Collaborator

Queued fe2636a79c85ff9bf1a8b79bd8358dea6c24d1b6 with parent f781bab, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (fe2636a79c85ff9bf1a8b79bd8358dea6c24d1b6): comparison url.

@nnethercote
Copy link
Contributor Author

The check and debug results here are decent, but the opt ones are not so good. Hmm.

@Muirrum
Copy link
Member

Muirrum commented Jul 24, 2020

@nnethercote This is a triage bump.

@nnethercote
Copy link
Contributor Author

This probably isn't going to lead anywhere useful.

@nnethercote
Copy link
Contributor Author

@SimonSapin: FYI, we discussed more shrinkage of grow_amortized() a while back. This was my latest attempt at improving it further. It's fiddly and unpredictable, I think a lot depends on the inlining choices.

@nnethercote nnethercote mentioned this pull request Dec 13, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nnethercote @rust-timer @bors @Manishearth @Muirrum @lcnr @Amanieu @rust-highfive